Skip to content

Revert "Pass GH token to release tag workflow" #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dceoy merged 1 commit into from
Aug 17, 2026
Merged

Revert "Pass GH token to release tag workflow" #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/post-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ jobs:
permissions:
contents: write
uses: dceoy/gha-for-devops/.github/workflows/github-major-version-tag.yml@main # zizmor: ignore[unpinned-uses]
secrets:
GH_TOKEN: ${{ secrets.GH_TOKEN }}
release-pins:

@opencode-agent opencode-agent Bot Aug 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

important · test-coverage-reviewer

Removing the GH_TOKEN secret passthrough from the tag job leaves the authentication contract with the remote github-major-version-tag.yml reusable workflow unvalidated. No test, actionlint rule, or CI dry-run checks that the called workflow can still create or update the major-version tag after this revert. Because the reusable workflow is referenced across repositories at the floating @main ref, actionlint cannot statically verify its required secrets, and the existing bats tests cover shell helpers rather than workflow contracts. If the called workflow still requires GH_TOKEN, the next release will fail to update the floating major-version tag (e.g., v1) without surfacing the problem until release time. Add a contract test that resolves the reusable workflow definition and validates the tag job's secrets/permissions, or include a dry-run/smoke step for the post-release workflow in CI.

permissions:
contents: write
Expand Down
Loading