Skip to content

Revert "Pass GH token to release tag workflow" - #100

Merged
dceoy merged 1 commit into
mainfrom
revert-98-agent/pass-release-tag-gh-token
Aug 17, 2026
Merged

Revert "Pass GH token to release tag workflow"#100
dceoy merged 1 commit into
mainfrom
revert-98-agent/pass-release-tag-gh-token

Conversation

@dceoy

@dceoy dceoy commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Reverts #98

@dceoy
dceoy merged commit e84cd36 into main Aug 17, 2026
9 checks passed
@dceoy
dceoy deleted the revert-98-agent/pass-release-tag-gh-token branch August 17, 2026 19:32

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCode PR Review: 1 inline finding(s).

uses: dceoy/gha-for-devops/.github/workflows/github-major-version-tag.yml@main # zizmor: ignore[unpinned-uses]
secrets:
GH_TOKEN: ${{ secrets.GH_TOKEN }}
release-pins:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

important · test-coverage-reviewer

Removing the GH_TOKEN secret passthrough from the tag job leaves the authentication contract with the remote github-major-version-tag.yml reusable workflow unvalidated. No test, actionlint rule, or CI dry-run checks that the called workflow can still create or update the major-version tag after this revert. Because the reusable workflow is referenced across repositories at the floating @main ref, actionlint cannot statically verify its required secrets, and the existing bats tests cover shell helpers rather than workflow contracts. If the called workflow still requires GH_TOKEN, the next release will fail to update the floating major-version tag (e.g., v1) without surfacing the problem until release time. Add a contract test that resolves the reusable workflow definition and validates the tag job's secrets/permissions, or include a dry-run/smoke step for the post-release workflow in CI.

@opencode-agent

Copy link
Copy Markdown

Review submitted: OpenCode PR Review on #100

Summary: 1 inline finding from test-coverage-reviewer. The other core reviewers (code-reviewer, performance-reviewer, documentation-accuracy-reviewer, security-code-reviewer) found no issues.

The retained finding flags that reverting the GH_TOKEN passthrough to the cross-repo reusable workflow leaves the authentication contract unvalidated by tests or CI dry-runs, which could delay detecting a release failure until the next release.

New%20session%20-%202026-08-17T19%3A31%3A59.354Z
opencode session  |  github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant