Revert "Pass GH token to release tag workflow" - #100
Conversation
This reverts commit 9f9bfcb.
| uses: dceoy/gha-for-devops/.github/workflows/github-major-version-tag.yml@main # zizmor: ignore[unpinned-uses] | ||
| secrets: | ||
| GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||
| release-pins: |
There was a problem hiding this comment.
important · test-coverage-reviewer
Removing the GH_TOKEN secret passthrough from the tag job leaves the authentication contract with the remote github-major-version-tag.yml reusable workflow unvalidated. No test, actionlint rule, or CI dry-run checks that the called workflow can still create or update the major-version tag after this revert. Because the reusable workflow is referenced across repositories at the floating @main ref, actionlint cannot statically verify its required secrets, and the existing bats tests cover shell helpers rather than workflow contracts. If the called workflow still requires GH_TOKEN, the next release will fail to update the floating major-version tag (e.g., v1) without surfacing the problem until release time. Add a contract test that resolves the reusable workflow definition and validates the tag job's secrets/permissions, or include a dry-run/smoke step for the post-release workflow in CI.
|
Review submitted: OpenCode PR Review on #100 Summary: 1 inline finding from The retained finding flags that reverting the |

Reverts #98