Skip to content

Add toArray method to existing VectorFloat<?> to access underlying float[] vectors representation #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add toArray method to existing VectorFloat<?> to access underlying float[] vectors representation #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions jvector-base/src/main/java/io/github/jbellis/jvector/vector/ArrayVectorFloat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,5 +123,10 @@ public int hashCode()
{
return this.getHashCode();
}

@Override
public float[] toArray() {
return get();
}
}

8 changes: 8 additions & 0 deletions jvector-base/src/main/java/io/github/jbellis/jvector/vector/types/VectorFloat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,12 @@ default int getHashCode() {
}
return result;
}

default float[] toArray() {
final float[] arr = new float[length()];
for (int i = 0; i < length(); ++i) {
arr[i] = get(i);
}
return arr;
}
}
5 changes: 5 additions & 0 deletions jvector-native/src/main/java/io/github/jbellis/jvector/vector/MemorySegmentVectorFloat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,9 @@ public boolean equals(Object o)
public int hashCode() {
return this.getHashCode();
}

@Override
public float[] toArray() {
return (float[])segment.heapBase().get();
}
}
Loading