Add toArray method to existing VectorFloat<?> to access underlying float[] vectors representation#697
Open
reta wants to merge 1 commit into
Open
Add toArray method to existing VectorFloat<?> to access underlying float[] vectors representation#697reta wants to merge 1 commit into
reta wants to merge 1 commit into
Conversation
…oat[] vectors representation Signed-off-by: Andriy Redko <drreta@gmail.com>
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
toArraymethod to existingVectorFloat<?>API. This is simpler change (since we could provide the default implementation usinglength()+get(index)but we cannot guarantee that everytoArrayimplementation is going to be zero copy, although we could document that.Closes #696