Skip to content

Fix dev-deps CI failures: detect pynwb num_samples support via __docval__ #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodyCBakerPhD wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dev-deps CI failures: detect pynwb num_samples support via __docval__ #1882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dandi/tests/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@

lgr = get_logger()

# TODO: simply always inject this when minimal supported pynwb is above 3.1.3
_imgseries_takes_num_samples = any(
arg["name"] == "num_samples"
for arg in getattr(ImageSeries.__init__, "__docval__", {}).get("args", [])
)
Comment thread
CodyCBakerPhD marked this conversation as resolved.

BIDS_TESTDATA_SELECTION = [
"asl003",
Expand Down Expand Up @@ -812,14 +817,17 @@ def _create_nwb_files(video_list: list[tuple[Path, Path]]) -> Path:
devices=[device],
)

image_series = ImageSeries(
imgseries_kwargs: dict[str, Any] = dict(
name=f"MouseWhiskers{i}",
format="external",
external_file=[str(vid_1), str(vid_2)],
starting_frame=[0, 2],
starting_time=0.0,
rate=150.0,
)
if _imgseries_takes_num_samples:
imgseries_kwargs["num_samples"] = 4
image_series = ImageSeries(**imgseries_kwargs)
nwbfile.add_acquisition(image_series)

nwbfile_path = base_nwb_path / f"{name}.nwb"
Expand Down
Loading