Fix dev-deps CI failures: detect pynwb num_samples support via __docval__#1882
Open
CodyCBakerPhD wants to merge 1 commit into
Open
Fix dev-deps CI failures: detect pynwb num_samples support via __docval__#1882CodyCBakerPhD wants to merge 1 commit into
CodyCBakerPhD wants to merge 1 commit into
Conversation
Contributor
Author
|
(certain parts of the daily tests have been failing for a while; trying to resolve) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1882 +/- ##
==========================================
- Coverage 76.79% 76.78% -0.01%
==========================================
Files 87 87
Lines 12805 12809 +4
==========================================
+ Hits 9833 9836 +3
- Misses 2972 2973 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CodyCBakerPhD
added
bug
CodyCBakerPhD
commented
Jun 23, 2026
CodyCBakerPhD
force-pushed
the
claude/bold-meitner-xoo59j
branch
from
9f315e3 to
2c94d7b
Compare
…al__ pynwb dev (post-3.1.3) added num_samples as a required parameter for ImageSeries when format='external' and rate-based timing is used. inspect.signature() cannot detect this because hdmf's @DocVal decorator hides parameters; use __docval__['args'] instead. Co-Authored-By: Claude <noreply@anthropic.com>
CodyCBakerPhD
force-pushed
the
claude/bold-meitner-xoo59j
branch
from
2c94d7b to
a4ffe2f
Compare
CodyCBakerPhD
changed the title
CodyCBakerPhD
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix failing
dev-depsCI jobs (ubuntu-latest, Python 3.10 and 3.14) caused by pynwb dev (post-3.1.3) addingnum_samplesas a required parameter forImageSerieswhenformat='external'and rate-based timing is used.Root cause
The test fixture in
dandi/tests/fixtures.pycreatesImageSeriesobjects withoutnum_samples, which pynwb dev now requires. A simple version check viainspect.signature()doesn't work because hdmf's@docvaldecorator wraps__init__and hides parameters from Python's inspection machinery. Instead, the parameter list is stored inImageSeries.__init__.__docval__["args"].Changes
dandi/tests/fixtures.py: Detectnum_samplessupport by inspecting__docval__["args"]and conditionally passnum_samples=4when creatingImageSeriesfixtures. Includes a TODO to simplify once the minimum supported pynwb is bumped above 3.1.3.