Conversation
Co-Authored-By: Kate Bowers <140750871+kate-bowers-broad@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated documentation to explain that presets determine join SQL and how to override it via Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/source/tutorials/cellprofiler_to_parquet.md (1)
131-136: Fix fenced block closures to avoid markdownlint/rendering issues.The fence closers are inconsistent (Line 131 and Line 152 use four backticks for inner 3-backtick blocks), which is likely causing the MD040 warning on Line 136.
Suggested markdown fence cleanup
-```` +``` ... -```` +```Also applies to: 152-152
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/source/tutorials/cellprofiler_to_parquet.md` around lines 131 - 136, The fenced code blocks that surround the paragraph "This is the main way to customize which columns are included in the joined output while still reusing the rest of the preset." use inconsistent closing fences (four backticks) and should be changed to match the inner triple-backtick blocks; update the closing fences around that block and the similar block later (the one around the inner ``` examples) so that all outer fences use three backticks to properly open and close the inner 3-backtick code examples and resolve the MD040/rendering issue.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/source/tutorials/cellprofiler_to_parquet.md`:
- Around line 118-121: Replace the hardcoded preset key in the example so it
uses the active preset variable instead of "cellprofiler_csv": update the
snippet that references config["cellprofiler_csv"] to use config[PRESET] (or the
actual preset variable name used elsewhere in the document) so that CUSTOM_JOINS
are pulled from the currently selected preset; ensure the PRESET (or preset)
identifier is the same symbol used earlier in the tutorial.
---
Nitpick comments:
In `@docs/source/tutorials/cellprofiler_to_parquet.md`:
- Around line 131-136: The fenced code blocks that surround the paragraph "This
is the main way to customize which columns are included in the joined output
while still reusing the rest of the preset." use inconsistent closing fences
(four backticks) and should be changed to match the inner triple-backtick
blocks; update the closing fences around that block and the similar block later
(the one around the inner ``` examples) so that all outer fences use three
backticks to properly open and close the inner 3-backtick code examples and
resolve the MD040/rendering issue.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a5820013-01b1-45cb-88f7-dd9b977e168f
📒 Files selected for processing (2)
docs/source/overview.mddocs/source/tutorials/cellprofiler_to_parquet.md
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Co-authored-by: Gregory Way <gregory.way@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/source/tutorials/cellprofiler_to_parquet.md`:
- Around line 135-144: The example output shown for print(custom_joins) is
inconsistent with the preceding code (missing COLUMNS(...), EXCLUDE(...), JOINs
and WHERE clauses); update the docs so the printed SQL either matches the actual
preset SQL (provide a faithful truncated excerpt from the real output) or
explicitly mark the block as abbreviated/pseudocode (e.g., prepend "Abbreviated
output:" or "Truncated for brevity:"); locate the mention of print(custom_joins)
in the tutorial and replace the current SQL block with the faithful truncated
output or a clear label indicating it is not the full SQL.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 94e08b38-58eb-4e81-b1e1-ee246165e1a2
📒 Files selected for processing (3)
.pre-commit-config.yamldocs/source/overview.mddocs/source/tutorials/cellprofiler_to_parquet.md
✅ Files skipped from review due to trivial changes (2)
- docs/source/overview.md
- .pre-commit-config.yaml
Co-Authored-By: Gregory Way <gregory.way@gmail.com>
Description
This PR seeks to improve tutorial preset documentation, especially when it comes to data and column management. It was inspired by comments from @kate-bowers-broad.
References #425
What is the nature of your change?
Checklist
Please ensure that all boxes are checked before indicating that a pull request is ready for review.
Summary by CodeRabbit