Skip to content

ci: bring back unit tests #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phip1611 merged 1 commit into from
May 22, 2026
+16 −0
Merged

ci: bring back unit tests #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,21 @@ jobs:
run: cargo build --locked --all --release --target=${{ matrix.target }}
- name: Check build did not modify any files
run: test -z "$(git status --porcelain)"
integration-x86-64-pr:
name: integration-x86-64-pr
needs: [preflight, dco, quality, build]
if: >-
needs.preflight.outputs.full == 'true' && needs.dco.result == 'success' && needs.quality.result == 'success' && needs.build.result == 'success'
timeout-minutes: 30
runs-on: ubuntu-latest
steps:
- name: Code checkout
uses: actions/checkout@v6
with:
fetch-depth: 0
- name: Run unit tests
Copy link
Copy Markdown

@Coffeeri Coffeeri May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit 6f07b15 you referenced also had installation steps for Docker and scripts/prepare_vdpa.sh. Are these no longer required?

I assume they're only needed for the left out integration tests (scripts/dev_cli.sh tests --integration --libc gnu). If we're only running unit tests here, maybe rename it from integration-x86-64-pr to unittests-x86-64-pr.
Feel free to resolve this yourself.

Copy link
Copy Markdown
Member Author

@phip1611 phip1611 May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit 6f07b15 you referenced also had installation steps for Docker and scripts/prepare_vdpa.sh. Are these no longer required?

Yes.

If we're only running unit tests here, maybe rename it from integration-x86-64-pr to unittests-x86-64-pr.

I wanted to keep merge conflict potential small. Although I see your point. No strong opinion tho

Copy link
Copy Markdown

@Coffeeri Coffeeri May 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to keep merge conflict potential small. Although I see your point. No strong opinion tho

I prefer unambiguousness, but have no hard feelings, either way, I approved it.

Copy link
Copy Markdown
Member Author

@phip1611 phip1611 May 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but have no hard feelings, either way, I approved it.

We need a bot to flip a coin in case both parties don't have a strong opinion, haha

Copy link
Copy Markdown

@arctic-alpaca arctic-alpaca May 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of renaming 🪙
Non-blocking though

run: scripts/dev_cli.sh tests --unit --libc gnu

# The single required-status check. Branch protection requires this one job.
all-green:
name: all-green
Expand All @@ -473,6 +488,7 @@ jobs:
- fuzz-build
- gitlint
- hadolint
- integration-x86-64-pr
- openapi
- package-consistency
- preflight
Expand Down
Loading