ci: bring back unit tests#161
Conversation
phip1611
force-pushed
the
bring-back-unit-tests
branch
from
b4a5954 to
f64501f
Compare
I accidentally removed them in 6f07b15. Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de> On-behalf-of: SAP philipp.schuster@sap.com
phip1611
force-pushed
the
bring-back-unit-tests
branch
from
f64501f to
848f177
Compare
| uses: actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Run unit tests |
There was a problem hiding this comment.
The commit 6f07b15 you referenced also had installation steps for Docker and scripts/prepare_vdpa.sh. Are these no longer required?
I assume they're only needed for the left out integration tests (scripts/dev_cli.sh tests --integration --libc gnu). If we're only running unit tests here, maybe rename it from integration-x86-64-pr to unittests-x86-64-pr.
Feel free to resolve this yourself.
There was a problem hiding this comment.
The commit 6f07b15 you referenced also had installation steps for Docker and scripts/prepare_vdpa.sh. Are these no longer required?
Yes.
If we're only running unit tests here, maybe rename it from integration-x86-64-pr to unittests-x86-64-pr.
I wanted to keep merge conflict potential small. Although I see your point. No strong opinion tho
There was a problem hiding this comment.
I wanted to keep merge conflict potential small. Although I see your point. No strong opinion tho
I prefer unambiguousness, but have no hard feelings, either way, I approved it.
There was a problem hiding this comment.
but have no hard feelings, either way, I approved it.
We need a bot to flip a coin in case both parties don't have a strong opinion, haha
There was a problem hiding this comment.
I'm in favor of renaming 🪙
Non-blocking though
4 participants
I accidentally removed them in 6f07b15.