fix: update subscriber role cache in real-time via EventSub events#3465
Open
servusrene wants to merge 1 commit intocrowbartools:v5from
Open
fix: update subscriber role cache in real-time via EventSub events#3465servusrene wants to merge 1 commit intocrowbartools:v5from
servusrene wants to merge 1 commit intocrowbartools:v5from
Conversation
The subscriber cache was only populated at startup and conditionally on chat reconnect, causing $userRoles to not reflect new or expired subs until restart. Now the cache is updated immediately on sub/resub/gift sub/upgrade events, refreshed on stream online and chat reconnect, and subscribers are removed via onChannelSubscriptionEnd.
Author
|
@zunderscore fyi |
Collaborator
No need to tag me. Someone from the dev team will review when one of us has a chance. |
Author
Sorry, I didn't know that. I just assumed that since you'd looked at the PR from @A-iko, you were in charge of that area. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
The subscriber cache was only populated at startup and conditionally on chat reconnect, causing
$userRolesto not reflect new or expired subs until restart. Now the cache is updated immediately on sub/resub/gift sub/upgrade events, refreshed on stream online and chat reconnect, and subscribers are removed viaonChannelSubscriptionEnd.Applicable Issues
Fixes #3462
Testing
Just subscribe to a channel and do not restart the app