fix: 3462 - Update subscriber tier on subscription event.#3463
fix: 3462 - Update subscriber tier on subscription event.#3463A-iko wants to merge 1 commit intocrowbartools:masterfrom
Conversation
|
This PR is targeting the |
Ah, I'm sorry, I must have skipped over that. I'll fix it in a bit. |
|
@A-iko I've also looked into the bug (weeks before) and prepared a commit, but I haven't submitted it yet. Would you like to take a look at it? In my opinion, the following is still missing:
Furthermore, you could adapt the part of your code where you add a subscriber to the cache to match the mod or VIP code, making it more consistent. EDIT: i have pushed it to gh: #3465 |
|
@servusrene Ah, what coincidence! I'm not opposed to just letting your PR take precedence here, your changes are definitely more robust. The things you mention as missing are definitely nice additions. I'm not really very familiar with the codebase yet so my implementation was a bit minimal. |
|
I'll close this PR, just going with @servusrene 's solution will save us all some time :) |
Description of the Change
Updates the Twitch subscriber role cache when sub-related events occur, so new subscribers and tier changes are reflected immediately instead of only after restart. This fixes cases where subscriber-specific TTS setups would stop matching until Firebot was restarted.
Applicable Issues
Fixes #3462
Testing
Manual:
Reviewed the sub, resub, gift sub, gift upgrade, and Prime upgrade event paths to ensure they now update the cached subscriber tier immediately.
Confirmed the project still builds successfully with grunt prep.
Injected a subscription event to see if tiers got updated.
Regression:
Verified edited files had no diagnostics after the change.