Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions PR_DESCRIPTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Fix typos and improve int input handling for OrganisasjonsnummerValidator
Comment thread
jodal marked this conversation as resolved.
Outdated

## Summary
This PR fixes several small issues found during a code review.

## Changes

### 🐛 Bug fix
**`OrganisasjonsnummerValidator` now accepts `int` input**

Previously, passing an integer like `123456789` would crash:
```python
>>> OrganisasjonsnummerValidator.validate_python(123456789)
AttributeError: 'int' object has no attribute 'replace'
```

Fixed by converting to `str` before calling `.replace()` in `_types.py`:
```python
# Before
BeforeValidator(lambda v: v.replace(" ", ""))

# After
BeforeValidator(lambda v: str(v).replace(" ", ""))
```

### ✏️ Typos in `EnhetQuery` (`_queries.py`)

| Before (typo) | After (correct) |
|---------------|-----------------|
| `registert_i_foretaksregisteret` | `registrert_i_foretaksregisteret` |
| `under_tvangsavvikling_eller_trangsopplosning` | `under_tvangsavvikling_eller_tvangsopplosning` |

### 📝 Documentation fix (`_client.py`)
Fixed incorrect docstring in `get_roller()` method:
```python
# Before
"""Get :class:`Enhet` given an organization number."""

# After
"""Get roles for an entity given an organization number."""
```

## Testing
All 40 existing tests pass.

## Breaking Changes
⚠️ The typo fixes are breaking changes for anyone using the old (misspelled) attribute names directly in their code.
2 changes: 1 addition & 1 deletion src/brreg/enhetsregisteret/_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def get_roller(
self,
organisasjonsnummer: Organisasjonsnummer,
) -> list[RolleGruppe]:
"""Get :class:`Enhet` given an organization number."""
"""Get roles for an entity given an organization number."""
Comment thread
jodal marked this conversation as resolved.
Outdated
orgnr = OrganisasjonsnummerValidator.validate_python(organisasjonsnummer)
with error_handler():
res = self._client.get(
Expand Down
6 changes: 3 additions & 3 deletions src/brreg/enhetsregisteret/_queries.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class EnhetQuery(Query):
)

#: Hvorvidt enheten er registrert i Foretaksregisteret
registert_i_foretaksregisteret: Optional[bool] = Field(
registrert_i_foretaksregisteret: Optional[bool] = Field(
default=None,
serialization_alias="registrertIForetaksregisteret",
)
Expand All @@ -111,8 +111,8 @@ class EnhetQuery(Query):
)

#: Hvorvidt enheten er registrert som under tvangsavvikling eller
#: tvangsopplosning
under_tvangsavvikling_eller_trangsopplosning: Optional[bool] = None
#: tvangsoppløsning
under_tvangsavvikling_eller_tvangsopplosning: Optional[bool] = None

#: Hvorvidt enheten er registrert som under avvikling
under_avvikling: Optional[bool] = None
Expand Down
2 changes: 1 addition & 1 deletion src/brreg/enhetsregisteret/_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

Organisasjonsnummer = Annotated[
str,
BeforeValidator(lambda v: v.replace(" ", "")),
BeforeValidator(lambda v: str(v).replace(" ", "")),
Comment thread
jodal marked this conversation as resolved.
Outdated
Field(min_length=9, max_length=9, pattern=r"^\d{9}$"),
]
OrganisasjonsnummerValidator: TypeAdapter[Organisasjonsnummer] = TypeAdapter(
Expand Down