Fix typos and improve int input handling #126
Open
+12
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typo: registert_i_foretaksregisteret -> registrert_i_foretaksregisteret - Fix typo: trangsopplosning -> tvangsopplosning - Fix OrganisasjonsnummerValidator to accept int input by converting to str first - Fix incorrect docstring in get_roller method
jodal
requested changes
Jan 23, 2026
| organisasjonsnummer: Organisasjonsnummer, | ||
| ) -> list[RolleGruppe]: | ||
| """Get :class:`Enhet` given an organization number.""" | ||
| """Get roles for an entity given an organization number.""" |
Member
There was a problem hiding this comment.
Your suggestion might be more useful, but to be consistent with the other docstrings change to:
Suggested change
| """Get roles for an entity given an organization number.""" | |
| """Get a list of :class:`RolleGruppe` given an organization number.""" |
src/brreg/enhetsregisteret/_types.py
Outdated
| Organisasjonsnummer = Annotated[ | ||
| str, | ||
| BeforeValidator(lambda v: v.replace(" ", "")), | ||
| BeforeValidator(lambda v: str(v).replace(" ", "")), |
Member
There was a problem hiding this comment.
If the org number has been converted to an int, it will have lost leading zeros, so we should left-pad with zeros until we have nine digits.
Suggested change
| BeforeValidator(lambda v: str(v).replace(" ", "")), | |
| BeforeValidator(lambda v: str(v).replace(" ", "").zfill(9)), |
The support for converting ints to org numbers deserves some test coverage.
PR_DESCRIPTION.md
Outdated
| @@ -0,0 +1,47 @@ | |||
| # Fix typos and improve int input handling for OrganisasjonsnummerValidator | |||
- Update get_roller docstring to use :class:\RolleGruppe\ for consistency - Add .zfill(9) to handle leading zeros when int is converted to org number - Add test coverage for int-to-org-number conversion - Remove PR_DESCRIPTION.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo: registert_i_foretaksregisteret -> registrert_i_foretaksregisteret
Fix typo: trangsopplosning -> tvangsopplosning
Fix OrganisasjonsnummerValidator to accept int input by converting to str first
Fix incorrect docstring in get_roller method