Skip to content

Enhance the logic of phi -> phi_start transform #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShangkunLi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enhance the logic of phi -> phi_start transform #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06ee88b
change the logic of phi->phi_start
ShangkunLi Mar 19, 2026
b971ecb
add phi handling in codegen pass
ShangkunLi Mar 19, 2026
364833f
modify tests
ShangkunLi Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .clangd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
CompileFlags:
Remove:
- -fno-lifetime-dse
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ lit.cfg
*.dot

# vscode config
.clangd
.cache
.vscode

Expand Down
15 changes: 8 additions & 7 deletions lib/NeuraDialect/Mapping/mapping_util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,9 @@ bool mlir::neura::isMaterializedReserveUser(Operation *user) {
if (isa<neura::PhiStartOp>(user)) {
return true;
}
if (isa<neura::PhiOp>(user)) {
return true;
}
return false;
}

Expand Down Expand Up @@ -1127,11 +1130,11 @@ bool mlir::neura::placeAndRoute(Operation *op, const MappingLoc &target_loc,
target_loc.resource, target_loc.time_step, latency, op);
if (bind_success) {
llvm::errs() << "[DEBUG] Bound multi-cycle op (latency=" << latency
<< ") " << *op << " onto loc: "
<< target_loc.resource->getType() << "#"
<< ") " << *op
<< " onto loc: " << target_loc.resource->getType() << "#"
<< target_loc.resource->getId()
<< " @t=" << target_loc.time_step << " to t="
<< (target_loc.time_step + latency - 1) << "\n";
<< " @t=" << target_loc.time_step
<< " to t=" << (target_loc.time_step + latency - 1) << "\n";
}
} else {
// For single-cycle ops, use default SINGLE_OCCUPY binding
Expand Down Expand Up @@ -1258,6 +1261,4 @@ int mlir::neura::getOpLatency(Operation *op) {
return 1;
}

bool mlir::neura::isMultiCycleOp(Operation *op) {
return getOpLatency(op) > 1;
}
bool mlir::neura::isMultiCycleOp(Operation *op) { return getOpLatency(op) > 1; }
Loading
Loading