joss: address reviewer 2 first-round comments (paper.md)#801
Open
ocots wants to merge 7 commits into
Open
Conversation
- AI disclosure: name Claude Sonnet 4.6 and Claude Opus 4.8 by Anthropic
- GPU claims: replace "seamless" with accurate language; clarify NVIDIA-only
constraint and ExaModels + MadNLP requirement in Summary, State of the
Field, and GPU trade-off sections
- JuliaCon 2023: add @caillau2023juliacon entry to paper.bib and cite it
in the Research Impact section
- "our plan is": rephrase to present tense ("our package provides")
- MATLAB: already fixed by author (Matlab -> MATLAB in State of the Field)
Per citation convention, package names with references first appear in the following paragraph; the Summary now only states the NVIDIA hardware constraint without repeating the package names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses the paper-related comments from reviewer 2 (first round) for the JOSS submission.
Changes to
joss/paper.md1. AI Usage Disclosure (line 175 of PDF)
Named the AI tools and versions explicitly, per the JOSS AI policy:
2. GPU claims (lines 21 and 87 of PDF)
Replaced "seamless" with accurate language and clarified that GPU support is currently NVIDIA-only. Updated in three places:
"currently limited to NVIDIA hardware"without naming packages (ExaModels.jl and MadNLP.jl are cited with references in the immediately following paragraph, per citation convention)"currently NVIDIA-only, via ExaModels.jl + MadNLP.jl":gputoken as the user-facing entry point and explicit statement that GPU is limited to NVIDIA hardware and the ExaModels + MadNLP combination3. JuliaCon 2023 archive (line 166 of PDF)
Added a citation to the JuliaCon 2023 presentation in the Research Impact section. Note: the documentation served as the presentation support, so there are no separate slides. References added to
paper.bib:4. "our plan is" → present tense (line 51 of PDF)
Rephrased to: "our package provides a modeler-agnostic approach, accepting general Julia code and leveraging various optimization solvers."
5. "Matlab" → "MATLAB" (line 71 of PDF)
Already fixed directly by the author.