Skip to content

[General] JOSS Paper review comments #799

@abhijit-c

Description

@abhijit-c

Hello,

I'm still working through my entire review of the (large!) codebase, but I've at least some feedback re. the JOSS paper that can be handled now. These are largely minor / nitpicks, I'm happy to say that overall it looks good to me!

All line numbers referenced aren't from the markdown file, but physical line numbers on the PDF.

  1. Re. the AI Usage Disclosure on line 175: Per the AI policy in JOSS (https://joss.readthedocs.io/en/latest/policies.html#ai-usage-policy) I believe the section ought to revised to include more details about the tool specifics and versions.
  2. Re. the GPU claim on line 21 and 87: Extremely minor nitpick, it feels slightly off to call GPU integration seamless when in reality it requires either ExaModels or MadNLP per http://control-toolbox.org/OptimalControl.jl/stable/manual-solve-gpu.html (and is NVIDIA only). I don't think these are unreasonable requirements, and I do think that OptimalControl.jl 's design that enables GPU solvers is a very worthy contribution worth calling out. However, I think at minimum, it should be clarified that it's NVIDIA only.
  3. Re. Line 166: I think would be a good idea to archives of one such workshop. I believe the package was presented in juliacon2025 , no? I'm happy if you don't want to do this though.
  4. Re. Line 51: "our plan is" should be present tense.
  5. Re. Line 71: "Matlab" -> "MATLAB"

Otherwise, happy with the paper, excellent work! I felt somewhat conflicted as to whether the illustrative example subsection belongs in a JOSS paper, but since the other reviewer feels strongly about expanding it even I'll refrain from suggesting anything since I don't have hard opinions on the matter.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions