Skip to content

fix: remove overly conservative context length check for @file (#12165) #12916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChenXin-2009 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −112
Open

fix: remove overly conservative context length check for @file (#12165) #12916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 3 additions & 112 deletions gui/src/components/mainInput/AtMentionDropdown/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
PlusIcon,
} from "@heroicons/react/24/outline";
import type { Editor } from "@tiptap/react";
import type { RangeInFile } from "core";

import {
forwardRef,
useContext,
Expand All @@ -25,7 +25,7 @@ import {
vscQuickInputBackground,
} from "../..";
import { IdeMessengerContext } from "../../../context/IdeMessenger";
import { useAppSelector } from "../../../redux/hooks";

import { setDialogMessage, setShowDialog } from "../../../redux/slices/uiSlice";
import { fontSize } from "../../../util";
import FileIcon from "../../FileIcon";
Expand Down Expand Up @@ -142,29 +142,10 @@ interface AtMentionDropdownProps {
onClose: () => void;
}

const formatFileSize = (fileSize: number) => {
const KB = 1000;
const MB = 1000_000;
const GB = 1000_000_000;

if (fileSize > GB) {
return `${(fileSize / GB).toFixed(1)} GB`;
} else if (fileSize > MB) {
return `${(fileSize / MB).toFixed(1)} MB`;
} else if (fileSize > KB) {
return `${(fileSize / KB).toFixed(1)} KB`;
}

return `${fileSize} byte${fileSize > 1 ? "s" : ""}`;
};

const AtMentionDropdown = forwardRef((props: AtMentionDropdownProps, ref) => {
const dispatch = useDispatch();

const ideMessenger = useContext(IdeMessengerContext);
const isInAgentMode = useAppSelector(
(store) => store.session.mode === "agent",
);

const [selectedIndex, setSelectedIndex] = useState(0);

Expand All @@ -180,89 +161,6 @@ const AtMentionDropdown = forwardRef((props: AtMentionDropdownProps, ref) => {

const [allItems, setAllItems] = useState<ComboBoxItem[]>([]);

async function isItemTooBig(
name: string,
query: string,
): Promise<[boolean, number]> {
const selectedCode: RangeInFile[] = [];
// Get context item from core
const contextResult = await ideMessenger.request(
"context/getContextItems",
{
name,
query,
fullInput: "",
selectedCode,
isInAgentMode,
},
);

if (contextResult.status === "error") {
return [false, -1];
}

const item = contextResult.content[0];

// Check if the context item exceeds the context length of the selected model
const result = await ideMessenger.request("isItemTooBig", {
item,
});

if (result.status === "error") {
return [false, -1];
}

const size = new Blob([item.content]).size;

return [result.content, size];
}

function handleItemTooBig(
fileExceeds: boolean,
fileSize: number,
item: ComboBoxItem,
) {
if (fileExceeds) {
props.editor
.chain()
.focus()
.command(({ tr, state }) => {
const text = state.doc.textBetween(
0,
state.selection.from,
"\n",
"\n",
); // Get the text before the cursor
const lastAtIndex = text.lastIndexOf("@");

if (lastAtIndex !== -1) {
// Delete text after the last "@"
tr.delete(lastAtIndex + 1, state.selection.from);
return true;
}
return false;
})
.run();

// Trigger warning message
void ideMessenger.ide.showToast(
"warning",
fileSize > 0
? "File exceeds model's context length"
: "Error loading file",
{
modal: true,
detail:
fileSize > 0
? `'${item.title}' cannot be added because it exceeds the model's allowed context length. File size: ${formatFileSize(fileSize)}`
: `'${item.title}' could not be loaded. Please check if the file exists and has the correct permissions.`,
},
);
} else {
props.command({ ...item, itemType: item.type });
}
}

useEffect(() => {
const items = [...props.items];
if (subMenuTitle === "Type to search docs") {
Expand Down Expand Up @@ -369,14 +267,7 @@ const AtMentionDropdown = forwardRef((props: AtMentionDropdownProps, ref) => {
}

if (item) {
if (item.type === "file" && item.query) {
void isItemTooBig(item.type, item.query).then(
([fileExceeds, fileSize]) =>
handleItemTooBig(fileExceeds, fileSize, item),
);
} else {
props.command({ ...item, itemType: item.type });
}
props.command({ ...item, itemType: item.type });
}
};

Expand Down
Loading