fix: remove overly conservative context length check for @file (#12165)#12916
Open
ChenXin-2009 wants to merge 1 commit into
Open
fix: remove overly conservative context length check for @file (#12165)#12916ChenXin-2009 wants to merge 1 commit into
ChenXin-2009 wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12165
The @file\ context provider had an \isItemTooBig\ check that incorrectly rejected files larger than ~16kB when using Ollama with \model: AUTODETECT. This happened because AUTODETECT skips \ensureModelInfo()\ (see \core/llm/llms/Ollama.ts:178), so \contextLength\ defaults to 8192 tokens instead of the actual model context size.
The formula used: \ okens > contextLength - maxTokens\ → \ okens > 8192 - 4096 = 4096\ rejected files that produce >4096 tokens (~16kB of text).
Fix
Removed the frontend-side \isItemTooBig\ check entirely, making @file\ consistent with @CurrentFile\ and all other context providers. The core \compileChatMessages\ function already handles context overflow gracefully.
Changes
Summary by cubic
Removed the overly conservative context-length check for
@filementions that blocked valid files (notably with Ollamamodel: AUTODETECT).@filenow behaves like@CurrentFile, with overflow handled by core logic.isItemTooBigcheck inAtMentionDropdown; all non-action items now go throughprops.command(...).Written for commit fff283d. Summary will update on new commits.