Skip to content

test: use compose rm for run cleanup - #5116

Draft
subotac wants to merge 8 commits into
containerd:mainfrom
subotac:fix/compose-test-cleanup
Draft

test: use compose rm for run cleanup#5116
subotac wants to merge 8 commits into
containerd:mainfrom
subotac:fix/compose-test-cleanup

Conversation

@subotac

@subotac subotac commented Aug 1, 2026

Copy link
Copy Markdown

Fixes #5112.

Update compose run test cleanup to invoke compose rm with the test's compose file and project context. The cleanup continues to stop containers and remove anonymous volumes before running compose down.

Tests:

  • go test ./cmd/nerdctl/compose -run TestThisDoesNotExist
  • go test ./pkg/composer -run TestThisDoesNotExist
  • go test ./pkg/cmd/compose
  • git diff --check

Signed-off-by: Subota Ivan <73706465+subotac@users.noreply.github.com>
@AkihiroSuda

Copy link
Copy Markdown
Member

Marking the PR as a draft as the CI is failing. Please click Ready for review when ready.

@AkihiroSuda
AkihiroSuda marked this pull request as draft August 1, 2026 19:13
Signed-off-by: Subota Ivan <73706465+subotac@users.noreply.github.com>
@subotac
subotac marked this pull request as ready for review August 1, 2026 20:32
Signed-off-by: Subota Ivan <73706465+subotac@users.noreply.github.com>
@AkihiroSuda
AkihiroSuda marked this pull request as draft August 2, 2026 15:35
subotac added 5 commits August 2, 2026 19:51
The initial Tigron cleanup has no project network to remove. Avoid entering the globally serialized compose down path before setup, which starved parallel compose run tests in CI.

Signed-off-by: Subota Ivan <73706465+subotac@users.noreply.github.com>
Signed-off-by: Subota Ivan <73706465+subotac@users.noreply.github.com>
Signed-off-by: Subota Ivan <73706465+subotac@users.noreply.github.com>
Signed-off-by: Subota Ivan <73706465+subotac@users.noreply.github.com>
Signed-off-by: Subota Ivan <73706465+subotac@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

testCase.Cleanup should use compose rm, not rm for cleaning up Compose tests

2 participants