Add require_crl_on_client_certificate field to certificate authority models#337
Conversation
…models Add the new boolean field to support CRL validation on client certificates for mTLS authentication. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a new optional flag to Certificate Authority-related IAM v2 models to represent whether CRL validation is required for client certificates, aligning the SDK with the corresponding API change.
Changes:
- Add
RequireCrlOnClientCertificate *booltoIamV2CertificateAuthority,IamV2CreateCertRequest, andIamV2UpdateCertRequest. - Add accessor helpers (
Get*,Get*Ok,Has*,Set*) for the new field across the three models. - Include the new field in
Redact()traversal andMarshalJSON()output when set.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| certificate-authority/v2/model_iam_v2_update_cert_request.go | Adds new optional boolean field with getters/setters and JSON serialization support for update requests. |
| certificate-authority/v2/model_iam_v2_create_cert_request.go | Adds new optional boolean field with getters/setters and JSON serialization support for create requests. |
| certificate-authority/v2/model_iam_v2_certificate_authority.go | Adds new optional boolean field with getters/setters and JSON serialization support on the CA resource model. |
Comments suppressed due to low confidence (3)
certificate-authority/v2/model_iam_v2_update_cert_request.go:59
- The generated markdown docs for this model appear out of sync with the new
require_crl_on_client_certificatefield (e.g.,certificate-authority/v2/docs/IamV2UpdateCertRequest.mddoes not mention it). Please regenerate/update thedocs/artifacts so SDK docs stay consistent with the models.
// Whether to require CRL validation on client certificates.
RequireCrlOnClientCertificate *bool `json:"require_crl_on_client_certificate,omitempty"`
certificate-authority/v2/model_iam_v2_create_cert_request.go:59
- The generated markdown docs for this model appear out of sync with the new
require_crl_on_client_certificatefield (e.g.,certificate-authority/v2/docs/IamV2CreateCertRequest.mddoes not mention it). Please regenerate/update thedocs/artifacts so SDK docs stay consistent with the models.
// Whether to require CRL validation on client certificates.
RequireCrlOnClientCertificate *bool `json:"require_crl_on_client_certificate,omitempty"`
certificate-authority/v2/model_iam_v2_certificate_authority.go:68
- The generated markdown docs for this model appear out of sync with the new
require_crl_on_client_certificatefield (e.g.,certificate-authority/v2/docs/IamV2CertificateAuthority.mddoes not mention it). Please regenerate/update thedocs/artifacts so SDK docs stay consistent with the models.
// Whether to require CRL validation on client certificates.
RequireCrlOnClientCertificate *bool `json:"require_crl_on_client_certificate,omitempty"`
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Aravind Khasibhatla (@akhasibhatla) unfortunately that's not sufficient, could you manually run |
|
Kostya Linou (@linouk23) - I ran cd ~/code/ccloud-sdk-go-v2/certificate-authority
go mod tidy
go vet -v ./...Output: All packages compiled and vetted without errors. Summary of ChangesFiles Modified:
Changes per file:
All changes follow the existing patterns in the codebase for optional boolean fields. |
Verification Approach for Auto-Generated SDKThis SDK is auto-generated code from OpenAPI specs (note: Verification Checklist
CLI Integration TestingThe CLI ( # In CLI repo with local SDK replacement
cd ~/code/cli
echo 'replace github.com/confluentinc/ccloud-sdk-go-v2/certificate-authority => ../ccloud-sdk-go-v2/certificate-authority' >> go.mod
go mod tidy
make testResult: IAM/Certificate Authority tests passed: The CLI PR with the corresponding changes: confluentinc/cli#3274 |
Go Vet Verification - Full OutputResult: No errors or warnings - all packages pass |
Related CLI PRThe CLI changes that use this SDK update are in: confluentinc/cli#3274 The CLI PR adds the |
Summary
RequireCrlOnClientCertificate *boolfield toIamV2CertificateAuthoritymodelRequireCrlOnClientCertificate *boolfield toIamV2CreateCertRequestmodelRequireCrlOnClientCertificate *boolfield toIamV2UpdateCertRequestmodelReferences
Test plan
🤖 Generated with Claude Code