Rename require_crl_on_client_certificate to require_crl_on_client_cert

[Aravind Khasibhatla (akhasibhatla)]

Summary

• Rename SDK field for better CLI UX and brevity
• Go field: RequireCrlOnClientCertificate -> RequireCrlOnClientCert
• JSON tag: require_crl_on_client_certificate -> require_crl_on_client_cert

Files Modified

• certificate-authority/v2/model_iam_v2_certificate_authority.go
• certificate-authority/v2/model_iam_v2_create_cert_request.go
• certificate-authority/v2/model_iam_v2_update_cert_request.go

Motivation

The CLI flag --require-crl-on-client-cert was shortened per review feedback. This SDK change aligns the JSON field name to be consistent.

References

• CLI PR: Add mTLS CRL Support to certificate-authority - CLI cli#3274
• Previous SDK PR (merged): Add require_crl_on_client_certificate field to certificate authority models #337

Verification

cd certificate-authority && go vet -v ./...

go vet -v output (click to expand)

internal/godebugs
internal/byteorder
internal/profilerecord
internal/coverage/rtcov
internal/unsafeheader
internal/msan
internal/goos
internal/goarch
internal/trace/tracev2
internal/asan
cmp
math/bits
internal/itoa
encoding
internal/runtime/math
unicode/utf8
internal/runtime/gc
unicode/utf16
unicode
crypto/internal/fips140/alias
crypto/internal/fips140deps/byteorder
internal/runtime/strconv
vendor/golang.org/x/crypto/cryptobyte/asn1
internal/nettrace
container/list
vendor/golang.org/x/crypto/internal/alias
log/internal
internal/goexperiment
crypto/internal/boring/sig
sync/atomic
crypto/internal/fips140/subtle
internal/cpu
internal/abi
crypto/internal/fips140deps/cpu
internal/synctest
internal/race
internal/chacha8rand
internal/bytealg
internal/runtime/sys
internal/runtime/atomic
internal/runtime/exithook
internal/sync
internal/stringslite
internal/runtime/maps
math
runtime
iter
weak
crypto/subtle
internal/reflectlite
maps
slices
errors
sync
crypto/internal/fips140cache
internal/oserror
internal/singleflight
internal/bisect
internal/testlog
unique
sort
path
io
vendor/golang.org/x/net/dns/dnsmessage
math/rand/v2
internal/godebug
crypto/internal/randutil
internal/saferio
strconv
hash
crypto/internal/fips140deps/godebug
bytes
strings
math/rand
encoding/base64
net/netip
crypto
vendor/golang.org/x/text/transform
hash/crc32
crypto/internal/impl
net/http/internal/ascii
bufio
crypto/internal/fips140
encoding/pem
regexp/syntax
reflect
crypto/internal/fips140/sha256
crypto/internal/fips140/sha512
crypto/internal/fips140/sha3
encoding/binary
internal/fmtsort
syscall
regexp
crypto/sha3
crypto/internal/fips140/hmac
internal/syscall/execenv
vendor/golang.org/x/crypto/internal/poly1305
crypto/internal/fips140hash
crypto/internal/fips140/check
internal/routebsd
crypto/fips140
crypto/internal/fips140/hkdf
crypto/internal/fips140/tls12
crypto/internal/fips140/bigmod
crypto/internal/fips140/edwards25519/field
time
crypto/internal/fips140/aes
crypto/tls/internal/fips140tls
internal/syscall/unix
crypto/internal/fips140/tls13
context
crypto/internal/fips140/edwards25519
crypto/x509/internal/macos
crypto/internal/fips140/nistec/fiat
io/fs
embed
internal/poll
internal/filepathlite
github.com/confluentinc/ccloud-sdk-go-v2/certificate-authority/v2/api
crypto/internal/fips140/nistec
os
io/ioutil
crypto/internal/sysrand
path/filepath
fmt
crypto/internal/entropy
log
encoding/hex
net/url
net/http/internal
mime/quotedprintable
encoding/xml
mime
crypto/internal/fips140/drbg
vendor/golang.org/x/net/http2/hpack
compress/flate
encoding/json
vendor/golang.org/x/text/unicode/norm
crypto/internal/fips140only
vendor/golang.org/x/text/unicode/bidi
crypto/internal/fips140/ecdh
crypto/internal/fips140/ed25519
crypto/internal/fips140/rsa
crypto/internal/fips140/ecdsa
compress/gzip
crypto/internal/fips140/aes/gcm
crypto/md5
crypto/hkdf
crypto/rc4
math/big
vendor/golang.org/x/text/secure/bidirule
crypto/internal/fips140/mlkem
crypto/dsa
crypto/cipher
encoding/asn1
crypto/elliptic
crypto/internal/boring
crypto/x509/pkix
crypto/des
vendor/golang.org/x/crypto/chacha20
vendor/golang.org/x/crypto/cryptobyte
vendor/golang.org/x/net/idna
crypto/internal/boring/bbig
crypto/sha512
crypto/hmac
crypto/rand
crypto/ecdh
crypto/aes
crypto/sha256
crypto/sha1
vendor/golang.org/x/crypto/chacha20poly1305
net
crypto/ed25519
crypto/ecdsa
crypto/rsa
crypto/internal/hpke
vendor/golang.org/x/net/http/httpproxy
net/textproto
vendor/golang.org/x/net/http/httpguts
crypto/x509
mime/multipart
crypto/tls
net/http/httptrace
net/http/internal/httpcommon
net/http
golang.org/x/net/context/ctxhttp
net/http/httputil
golang.org/x/oauth2/internal
golang.org/x/oauth2
github.com/confluentinc/ccloud-sdk-go-v2/certificate-authority/v2

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR renames the Certificate Authority SDK model field and corresponding JSON property from require_crl_on_client_certificate to the shorter require_crl_on_client_cert to align with updated CLI flag naming and improve UX consistency.

Changes:

• Renamed Go struct field and helper methods from RequireCrlOnClientCertificate to RequireCrlOnClientCert in the CA models.
• Updated JSON tags and MarshalJSON() serialization keys to require_crl_on_client_cert.
• Updated Redact() recursion calls to reference the renamed field.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
certificate-authority/v2/model_iam_v2_certificate_authority.go	Renames the response model field + helpers and updates JSON serialization key.
certificate-authority/v2/model_iam_v2_create_cert_request.go	Renames the create request field + helpers and updates JSON serialization key.
certificate-authority/v2/model_iam_v2_update_cert_request.go	Renames the update request field + helpers and updates JSON serialization key.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Kostya Linou (linouk23)]

I don't think it's a good idea, as the naming needs to match API 1:1: https://github.com/confluentinc/api/blob/master/certificate-authority/minispec.yaml#L131

[Aravind Khasibhatla (akhasibhatla)]

I don't think it's a good idea, as the naming needs to match API 1:1: https://github.com/confluentinc/api/blob/master/certificate-authority/minispec.yaml#L131

Kostya Linou (@linouk23) Fair point, please note Cynthia Qin (@cqin-confluent) will be helping us out here going forward. I was just getting started on this change.

[Kostya Linou (linouk23)]

Sounds good! Let's make sure we follow https://confluentinc.atlassian.net/wiki/spaces/ADP/pages/2791867798/Adding+a+new+SDK+to+ccloud-sdk-go-v2-internal when making changes to this repository, as opposed to updating these files manually.

[Aravind Khasibhatla (akhasibhatla)]

We will no longer need this PR, and Cynthia Qin (@cqin-confluent) will take up updating confluentinc/cli#3274