-
Notifications
You must be signed in to change notification settings - Fork 0
Versioning of sculptor and Pictor #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3cbe0ff
chore: update package name to @code0-tech/sculptor and reset version …
nicosammito 0150123
feat: write sculptor and pictor versions to .env.local during edition…
nicosammito 00a8e75
feat: display sculptor and pictor versions from environment variables…
nicosammito f41f67d
chore: remove env variables from next.config.ts
nicosammito 13249a2
fix: update edition script to replace version variables in .env.local…
nicosammito 3bb3bcd
chore: add default environment variables to .env.local
nicosammito 8c6ecd3
chore: update package name and version in package-lock.json
nicosammito 2fad8ff
chore: read sculptor and pictor versions from package-lock.json in ed…
nicosammito ecfee1c
chore: update default pictor version in .env.local
nicosammito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| EDITION=ce | ||
| SAGITTARIUS_GRAPHQL_URL=http://localhost:3010/graphql | ||
| NEXT_PUBLIC_SCULPTOR_VERSION=0.0.0 | ||
| NEXT_PUBLIC_PICTOR_VERSION=0.0.0-mvp.45 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which values here are required?
NEXT_PUBLIC_SCULPTOR_VERSIONandNEXT_PUBLIC_PICTOR_VERSIONare managed by the set-edition script. Are the other two variables required or what are they used for?More importantly, we don't know the
SAGITTARIUS_GRAPHQL_URLduring build, so this variable must be overridable at runtime without rebuilding.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to use a Nginx server for that