Conversation
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/sculptor/-/pipelines/2340529865 Status: Passed |
Taucher2003
left a comment
Taucher2003
left a comment
There was a problem hiding this comment.
Does this have to be done with environment variables? Feels a bit wrong, but if that is the best option for a next app, then its fine.
There was a problem hiding this comment.
Which values here are required?
NEXT_PUBLIC_SCULPTOR_VERSION and NEXT_PUBLIC_PICTOR_VERSION are managed by the set-edition script. Are the other two variables required or what are they used for?
More importantly, we don't know the SAGITTARIUS_GRAPHQL_URL during build, so this variable must be overridable at runtime without rebuilding.
There was a problem hiding this comment.
We decided to use a Nginx server for that
… in settings page
… instead of appending
nicosammito
force-pushed
the
feat/versioning
branch
from
6220338 to
ecfee1c
Compare
2 participants
No description provided.