Skip to content

fix: Do not specify version when creating extensions #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ardentperf wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −6
Open

fix: Do not specify version when creating extensions #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dagger/maintenance/testingvalues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
type ExtensionSpec struct {
Ensure string `yaml:"ensure"`
Name string `yaml:"name"`
Version string `yaml:"version"`
}

type DatabaseConfig struct {
Expand Down Expand Up @@ -123,7 +122,6 @@ func generateDatabaseConfig(extensionInfos []*testingExtensionInfo) *DatabaseCon
ExtensionSpec{
Ensure: "present",
Name: info.SQLName,
Version: info.Version,
},
)
}
Expand Down
6 changes: 2 additions & 4 deletions test/check-extension.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ spec:
env:
- name: EXT_SQL_NAME
value: ($values.sql_name)
- name: EXT_VERSION
value: ($values.version)
- name: CREATE_EXTENSION
value: (to_string($values.create_extension))
- name: DB_URI
Expand All @@ -30,5 +28,5 @@ spec:
exit 0
fi
DB_URI=$(echo $DB_URI | sed "s|/\*|/|")
test "$(psql "$DB_URI" -tAc "SELECT EXISTS (SELECT FROM pg_catalog.pg_extension WHERE extname = '${EXT_SQL_NAME}' AND extversion = '${EXT_VERSION}')" -q)" = "t"
echo "Extension '${EXT_SQL_NAME} v${EXT_VERSION}' is installed!"
test "$(psql "$DB_URI" -tAc "SELECT EXISTS (SELECT FROM pg_catalog.pg_extension WHERE extname = '${EXT_SQL_NAME}')" -q)" = "t"
echo "Extension '${EXT_SQL_NAME}' is installed!"