fix: Do not specify version when creating extensions#144
Open
ardentperf wants to merge 1 commit intocloudnative-pg:mainfrom
Open
fix: Do not specify version when creating extensions#144ardentperf wants to merge 1 commit intocloudnative-pg:mainfrom
ardentperf wants to merge 1 commit intocloudnative-pg:mainfrom
Conversation
When create_extension=true, omit the version from the Database extensions spec so CNPG uses the extension's default_version from the control file. The OCI image version annotation reflects the package version, which can differ from the SQL extension version (e.g. pg_cron package 1.6.7 vs control default_version 1.6). This problem was encountered while working on cloudnative-pg#139 Also update the smoke test verification to check only that the extension exists, without requiring a specific version number. Signed-off-by: Jeremy Schneider <schneider@ardentperf.com>
Contributor
|
I am not entirely convinced about skipping the version in the tests. Consider that at the moment we are not doing an important test, the upgrade one, and that at some point we must introduce it. I was chatting with @NiccoloFei on Slack and he was suggesting to add a field called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When create_extension=true, omit the version from the Database extensions spec so CNPG uses the extension's default_version from the control file. The OCI image version annotation reflects the package version, which can differ from the SQL extension version (e.g. pg_cron package 1.6.7 vs control default_version 1.6). This problem was encountered while working on #139
Also update the smoke test verification to check only that the extension exists, without requiring a specific version number.