Generated runtime.env adds $GEM_HOME/bin to $PATH#66
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the generated bosh/runtime.env to include gem-installed executables by adding $GEM_HOME/bin to $PATH, and tightens shell quoting in packaging scripts to avoid word-splitting issues.
Changes:
- Extend generated
runtime.envPATH to include${GEM_HOME}/bin(in addition to${BOSH_INSTALL_TARGET}/bin). - Improve shell robustness in packaging scripts by quoting command substitutions and variables, and separating assignment from
export. - Document
bosh_bundle_localin README (currently with a command-name mismatch noted in review).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates the list of functions provided by compile.env (needs a small correction to match implementation). |
| ci/templates/src/compile.env.erb | Modifies bosh_generate_runtime_env to prepend ${GEM_HOME}/bin to PATH. |
| ci/templates/packages/ruby/packaging.erb | Improves quoting and makes PACKAGE_NAME export clearer/safer. |
| ci/templates/packages/ruby-test/packaging.erb | Quotes cd target to avoid word-splitting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
03e960d to
919f154
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
ci/templates/packages/ruby/packaging.erb:15
- Only updating this ERB template leaves the already-rendered
packages/ruby-*/packagingscripts unchanged. For example,packages/ruby-3.3/packagingstill contains the previous unquotedif [ $(uname -s) == "Darwin" ]; thenand won’t receive the quoting fix until the package templates are re-rendered and committed.
if [ "$(uname -s)" == "Darwin" ]; then
if brew --prefix openssl; then
brew_prefix_openssl="$(brew --prefix openssl)"
PATH="${brew_prefix_openssl}/bin:$PATH"
with_openssl_dir="--with-openssl-dir=$brew_prefix_openssl"
fi
fi
mkocher
approved these changes
Jul 15, 2026
ystros
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE pipelines for each package line must be run before the changes will be reflected in each
ruby-$MAJOR.$MINORpackage