Skip to content

Generated runtime.env adds $GEM_HOME/bin to $PATH#66

Merged
aramprice merged 1 commit into
mainfrom
path-has-gem-bin
Jul 15, 2026
Merged

Generated runtime.env adds $GEM_HOME/bin to $PATH#66
aramprice merged 1 commit into
mainfrom
path-has-gem-bin

Conversation

@aramprice

@aramprice aramprice commented Jul 14, 2026

Copy link
Copy Markdown
Member

NOTE pipelines for each package line must be run before the changes will be reflected in each ruby-$MAJOR.$MINOR package

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the generated bosh/runtime.env to include gem-installed executables by adding $GEM_HOME/bin to $PATH, and tightens shell quoting in packaging scripts to avoid word-splitting issues.

Changes:

  • Extend generated runtime.env PATH to include ${GEM_HOME}/bin (in addition to ${BOSH_INSTALL_TARGET}/bin).
  • Improve shell robustness in packaging scripts by quoting command substitutions and variables, and separating assignment from export.
  • Document bosh_bundle_local in README (currently with a command-name mismatch noted in review).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
README.md Updates the list of functions provided by compile.env (needs a small correction to match implementation).
ci/templates/src/compile.env.erb Modifies bosh_generate_runtime_env to prepend ${GEM_HOME}/bin to PATH.
ci/templates/packages/ruby/packaging.erb Improves quoting and makes PACKAGE_NAME export clearer/safer.
ci/templates/packages/ruby-test/packaging.erb Quotes cd target to avoid word-splitting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

ci/templates/packages/ruby/packaging.erb:15

  • Only updating this ERB template leaves the already-rendered packages/ruby-*/packaging scripts unchanged. For example, packages/ruby-3.3/packaging still contains the previous unquoted if [ $(uname -s) == "Darwin" ]; then and won’t receive the quoting fix until the package templates are re-rendered and committed.
if [ "$(uname -s)" == "Darwin" ]; then
  if brew --prefix openssl; then
    brew_prefix_openssl="$(brew --prefix openssl)"
    PATH="${brew_prefix_openssl}/bin:$PATH"
    with_openssl_dir="--with-openssl-dir=$brew_prefix_openssl"
  fi
fi

Comment thread ci/templates/src/compile.env.erb
Comment thread ci/templates/packages/ruby-test/packaging.erb

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jul 15, 2026
@aramprice aramprice merged commit 05ced83 into main Jul 15, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jul 15, 2026
@aramprice aramprice deleted the path-has-gem-bin branch July 15, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants