Skip to content

Use ruby package's runtime.env generation func#2777

Merged
aramprice merged 1 commit into
mainfrom
use-runtime.env-generation
Jul 15, 2026
Merged

Use ruby package's runtime.env generation func#2777
aramprice merged 1 commit into
mainfrom
use-runtime.env-generation

Conversation

@aramprice

@aramprice aramprice commented Jul 14, 2026

Copy link
Copy Markdown
Member
  • remove hard-coded GEM_HOME
  • move BUNDLE_GEMFILE out of BPM into start scripts

Requires cloudfoundry/bosh-package-ruby-release#66

AND ruby-package pipelines need to be (manually) run to regenerate various files.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Packaging scripts now generate runtime.env after local bundling for the director, health monitor, and NATS packages. Job startup templates source package-specific runtime environments, use BUNDLE_GEMFILE for Bundler configuration, and remove previous GEM_HOME settings. BPM templates no longer inject duplicate Bundler environment blocks, while existing executable configuration paths remain unchanged.

Suggested reviewers: selzoc

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the change briefly but misses the required template sections and most requested context, tests, release notes, and breaking-change details. Expand the PR description to fill each required section in the template, including context, tests run, release notes, breaking-change status, and team tags.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly reflects the main change: generating and using the Ruby package runtime.env instead of the prior setup.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch use-runtime.env-generation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates BOSH Ruby-based packages/jobs to rely on the ruby package’s generated bosh/runtime.env (instead of hard-coding GEM_HOME) and moves BUNDLE_GEMFILE configuration out of BPM process definitions into the job start scripts.

Changes:

  • Call bosh_generate_runtime_env during packaging for director, nats, and health_monitor.
  • Remove BUNDLE_GEMFILE from BPM configs and set it in the job wrapper scripts instead.
  • Stop exporting hard-coded GEM_HOME in job scripts; source package-specific bosh/runtime.env instead.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/nats/packaging Generate package runtime env during compile via bosh_generate_runtime_env.
packages/health_monitor/packaging Generate package runtime env during compile via bosh_generate_runtime_env.
packages/director/packaging Generate package runtime env during compile via bosh_generate_runtime_env.
jobs/nats/templates/bpm.yml Remove BPM-level BUNDLE_GEMFILE env injection for bosh_nats_sync.
jobs/nats/templates/bosh_nats_sync Source package runtime env and export BUNDLE_GEMFILE in the wrapper script.
jobs/health_monitor/templates/health_monitor Source package runtime env and export BUNDLE_GEMFILE in the wrapper script.
jobs/health_monitor/templates/bpm.yml Remove BPM-level BUNDLE_GEMFILE env injection (but currently breaks proxy env mutations; needs fix).
jobs/director/templates/env.erb Source director package runtime env and remove hard-coded GEM_HOME export.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread jobs/health_monitor/templates/bpm.yml
- remove hard-coded GEM_HOME
- move BUNDLE_GEMFILE out of BPM into start scripts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comment thread packages/nats/packaging
Comment thread packages/health_monitor/packaging
Comment thread packages/director/packaging
@aramprice aramprice merged commit 98c3bb4 into main Jul 15, 2026
25 checks passed
@aramprice aramprice deleted the use-runtime.env-generation branch July 15, 2026 20:45
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants