Use ruby package's runtime.env generation func#2777
Conversation
WalkthroughPackaging scripts now generate Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates BOSH Ruby-based packages/jobs to rely on the ruby package’s generated bosh/runtime.env (instead of hard-coding GEM_HOME) and moves BUNDLE_GEMFILE configuration out of BPM process definitions into the job start scripts.
Changes:
- Call
bosh_generate_runtime_envduring packaging fordirector,nats, andhealth_monitor. - Remove
BUNDLE_GEMFILEfrom BPM configs and set it in the job wrapper scripts instead. - Stop exporting hard-coded
GEM_HOMEin job scripts; source package-specificbosh/runtime.envinstead.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/nats/packaging | Generate package runtime env during compile via bosh_generate_runtime_env. |
| packages/health_monitor/packaging | Generate package runtime env during compile via bosh_generate_runtime_env. |
| packages/director/packaging | Generate package runtime env during compile via bosh_generate_runtime_env. |
| jobs/nats/templates/bpm.yml | Remove BPM-level BUNDLE_GEMFILE env injection for bosh_nats_sync. |
| jobs/nats/templates/bosh_nats_sync | Source package runtime env and export BUNDLE_GEMFILE in the wrapper script. |
| jobs/health_monitor/templates/health_monitor | Source package runtime env and export BUNDLE_GEMFILE in the wrapper script. |
| jobs/health_monitor/templates/bpm.yml | Remove BPM-level BUNDLE_GEMFILE env injection (but currently breaks proxy env mutations; needs fix). |
| jobs/director/templates/env.erb | Source director package runtime env and remove hard-coded GEM_HOME export. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- remove hard-coded GEM_HOME - move BUNDLE_GEMFILE out of BPM into start scripts
1b24322 to
d3f1021
Compare
Requires cloudfoundry/bosh-package-ruby-release#66
AND ruby-package pipelines need to be (manually) run to regenerate various files.