Conversation
|
UnknownError: "Internal server error" |
|
@ryanking13 Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
|
/bonk try again |
There was a problem hiding this comment.
Review Summary
The PR makes two changes: (1) switches the Python package fetch URL from GCS to R2, and (2) removes the now-unused WORKERD_INDEX_URL/indexURL parameter from the TS layer. Both are reasonable cleanup. A few items to address:
- [before-merge]
py_wd_test.bzlhas disk cache intentionally disabled with aTODO(before merge)comment — needs to be reverted before landing. - [nit] The hardcoded
indexURL = ''could use a clarifying comment explaining why it's empty now. - The
proxy.jssimplification correctly removes hostnames that are no longer reachable after the URL migration. - No remaining references to the old GCS URL or
pyodide-packages.runtime-playgroundhostname exist in the codebase.
This review was generated by an AI assistant (ask-bonk) and may contain inaccuracies.
| # +pyodide+ is a bzlmod canonical repository name | ||
| args.append("../+pyodide+all_pyodide_wheels_%s" % pkg_tag) | ||
| # # +pyodide+ is a bzlmod canonical repository name | ||
| # args.append("../+pyodide+all_pyodide_wheels_%s" % pkg_tag) |
There was a problem hiding this comment.
This is marked TODO(before merge). Just flagging for visibility — make sure to revert the disk cache disablement before this lands. The commented-out lines (35-39) should be restored to:
| # args.append("../+pyodide+all_pyodide_wheels_%s" % pkg_tag) | |
| args = args + ["--pyodide-package-disk-cache-dir"] | |
| # +pyodide+ is a bzlmod canonical repository name | |
| args.append("../+pyodide+all_pyodide_wheels_%s" % pkg_tag) |
There was a problem hiding this comment.
Reverted after testing locally
|
Review posted successfully on PR #6410. Here's a summary of what I flagged:
The URL migration itself from GCS ( |
707e0a4 to
e953b6f
Compare
Replaces the Python fetch URL from GCS to R2. Note that our prod system uses a different path so this only affect workerd.
This is currently blocked by cloudflare/pyodide-build-scripts#14 (All 0.28.2 tests pass while 0.26.0a2 tests fail), hence opening as a draft.DoneI also removed
WORKERD_INDEX_URLwhich I don't think we use anymore (no package loading in the runtime).