Skip to content

Commit 707e0a4

Browse files
committed
Replace the python package URL to R2
1 parent a9ed77f commit 707e0a4

6 files changed

Lines changed: 8 additions & 23 deletions

File tree

src/pyodide/internal/metadata.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,6 @@ export const MEMORY_SNAPSHOT_READER = MetadataReader.hasMemorySnapshot()
3030
// Packages
3131
export const PACKAGES_VERSION = MetadataReader.getPackagesVersion();
3232
export const USING_OLDEST_PACKAGES_VERSION = PACKAGES_VERSION === '20240829.4';
33-
// TODO: pyodide-packages.runtime-playground.workers.dev points at a worker which redirects requests
34-
// to the public R2 bucket URL at pub-45d734c4145d4285b343833ee450ef38.r2.dev. We should remove
35-
// this worker and point at our prod bucket.
36-
export const WORKERD_INDEX_URL = USING_OLDEST_PACKAGES_VERSION
37-
? 'https://pyodide-packages.runtime-playground.workers.dev/' +
38-
PACKAGES_VERSION +
39-
'/'
40-
: 'https://python-packages.edgeworker.net/' + PACKAGES_VERSION + '/';
4133
// The package lock is embedded in the binary. See `getPyodideLock` and `packageLocks`.
4234
export const LOCKFILE = JSON.parse(
4335
MetadataReader.getPackagesLock()

src/pyodide/internal/python.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,6 @@ function compileModuleFromReadOnlyFS(
238238
export function loadPyodide(
239239
isWorkerd: boolean,
240240
lockfile: PackageLock,
241-
indexURL: string,
242241
customSerializedObjects: CustomSerializedObjects
243242
): Pyodide {
244243
try {
@@ -248,7 +247,7 @@ export function loadPyodide(
248247
Module.compileModuleFromReadOnlyFS = compileModuleFromReadOnlyFS;
249248
Module.API.config.jsglobals = globalThis;
250249
if (isWorkerd) {
251-
Module.API.config.indexURL = indexURL;
250+
Module.API.config.indexURL = '';
252251
Module.API.config.resolveLockFilePromise!(lockfile);
253252
}
254253
Module.setUnsafeEval(UnsafeEval);

src/pyodide/python-entrypoint-helper.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import {
1818
MAIN_MODULE_NAME,
1919
SHOULD_SNAPSHOT_TO_DISK,
2020
TRANSITIVE_REQUIREMENTS,
21-
WORKERD_INDEX_URL,
2221
WORKFLOWS_ENABLED,
2322
} from 'pyodide-internal:metadata';
2423
import {
@@ -153,7 +152,7 @@ async function getPyodide(): Promise<Pyodide> {
153152
return pyodidePromise;
154153
}
155154
pyodidePromise = (async function (): Promise<Pyodide> {
156-
const pyodide = loadPyodide(IS_WORKERD, LOCKFILE, WORKERD_INDEX_URL, {
155+
const pyodide = loadPyodide(IS_WORKERD, LOCKFILE, {
157156
pyodide_entrypoint_helper: get_pyodide_entrypoint_helper(),
158157
cloudflare_compat_flags: COMPATIBILITY_FLAGS,
159158
});

src/workerd/api/pyodide/pyodide.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ WD_STRONG_BOOL(IsValidating);
3030
WD_STRONG_BOOL(IsWorkerd);
3131
WD_STRONG_BOOL(SnapshotToDisk);
3232

33-
const auto PYTHON_PACKAGES_URL =
34-
"https://storage.googleapis.com/cloudflare-edgeworker-python-packages/";
33+
const auto PYTHON_PACKAGES_URL = "https://pyodide-capnp-bin.edgeworker.net/";
3534
class PyodideBundleManager {
3635
public:
3736
void setPyodideBundleData(kj::String version, kj::Array<unsigned char> data) const;

src/workerd/server/tests/python/py_wd_test.bzl

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,11 @@ def _py_wd_test_helper(
3232

3333
pkg_tag = BUNDLE_VERSION_INFO[python_flag]["packages"]
3434
data = data + ["@all_pyodide_wheels_%s//:whls" % pkg_tag]
35-
args = args + ["--pyodide-package-disk-cache-dir"]
35+
# TODO(before merge): revert. Temporarily disable disk cache to test loading from real remote storage
36+
# args = args + ["--pyodide-package-disk-cache-dir"]
3637

37-
# +pyodide+ is a bzlmod canonical repository name
38-
args.append("../+pyodide+all_pyodide_wheels_%s" % pkg_tag)
38+
# # +pyodide+ is a bzlmod canonical repository name
39+
# args.append("../+pyodide+all_pyodide_wheels_%s" % pkg_tag)
3940

4041
load_snapshot = None
4142
pyodide_version = BUNDLE_VERSION_INFO[python_flag]["real_pyodide_version"]

src/workerd/server/tests/python/sdk/proxy.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
export default {
22
async fetch(req, env) {
33
const url = new URL(req.url);
4-
if (
5-
url.hostname == 'python-packages.edgeworker.net' ||
6-
url.hostname == 'pyodide-packages.runtime-playground.workers.dev'
7-
) {
8-
return env.INTERNET.fetch(req);
9-
} else if (url.hostname == 'example.com') {
4+
if (url.hostname == 'example.com') {
105
return env.PYTHON.fetch(req);
116
}
127

0 commit comments

Comments
 (0)