Conversation
7ad9a2f to
c2d0dd1
Compare
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR enables ESLint on .wd-test JS files by integrating lint_test into wd_test.bzl, adding workerd-specific globals, and fixing the resulting lint violations across ~80 files.
- [MEDIUM]
assert.deepEqual;is a no-op expression (property access, not a function call) -- the eslint-disable suppresses the symptom but leaves a likely pre-existing bug unaddressed. - [LOW]
r2-test.jsfall-through comments -- the// falls throughcomments are technically accurate (the code can fall through syntactically) but in practice the innerswitchcases alwaysreturn. Addingbreakstatements would be more correct than endorsing the fall-throughs with comments.
The remaining changes (unused var prefixes, dead code removal, var→let, empty catch/loop bodies, removed stale eslint-disable comments) look correct. The encoding-test.js fix and net-nodejs-test.js reject→throw fix are genuine bug corrections.
This review was generated by an AI assistant and may contain inaccuracies.
|
To https://github.com/cloudflare/workerd.git |
|
@anonrig Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
c2d0dd1 to
93c279b
Compare
|
Force pushed to fix conflicts & add missing copyright headers to tests |
93c279b to
1e8b2a1
Compare
1e8b2a1 to
199c88f
Compare
No description provided.