enable eslint on wd-test files

Author: anonrig

build/lint_test.bzl

@@ -5,7 +5,8 @@ def lint_test(
         eslintrc_json,
         tsconfig_json,
         srcs,
-        data = []):
+        data = [],
+        no_copy_to_bin = []):
     js_srcs = [src for src in srcs if src.endswith(".ts") or src.endswith(".mts") or src.endswith(".js") or src.endswith(".mjs")]
 
     eslint_bin.eslint_test(
@@ -21,6 +22,7 @@ def lint_test(
             "@workerd//tools:base-tsconfig",
             "@workerd//tools:base-eslint",
         ],
+        no_copy_to_bin = no_copy_to_bin,
         tags = ["lint"],
         target_compatible_with = select({
             "@platforms//os:windows": ["@platforms//:incompatible"],

build/wd_test.bzl

@@ -1,11 +1,13 @@
 load("@aspect_rules_ts//ts:defs.bzl", "ts_config", "ts_project")
+load("@workerd//:build/lint_test.bzl", "lint_test")
 
 def wd_test(
         src,
         data = [],
         name = None,
         args = [],
         ts_deps = [],
+        lint = True,
         python_snapshot_test = False,
         generate_default_variant = True,
         generate_all_autogates_variant = True,
@@ -63,6 +65,20 @@ def wd_test(
         )
         data += [js_src.removesuffix(".ts") + ".js" for js_src in ts_srcs]
 
+    if lint:
+        lint_srcs = [s for s in data if (s.endswith(".ts") or s.endswith(".mts") or s.endswith(".js") or s.endswith(".mjs")) and not s.startswith("../") and not s.startswith("//")]
+        if lint_srcs:
+            lint_test(
+                name = name,
+                eslintrc_json = "@workerd//tools:base.eslint.config.mjs",
+                tsconfig_json = "@workerd//tools:base.tsconfig.json",
+                srcs = lint_srcs,
+                no_copy_to_bin = [
+                    "@workerd//tools:base.eslint.config.mjs",
+                    "@workerd//tools:base.tsconfig.json",
+                ],
+            )
+
     # Add initial arguments for `workerd test` command.
     base_args = [
         "$(location //src/workerd/server:workerd_cross)",

src/cloudflare/internal/test/ai/ai-api-test.js

@@ -58,6 +58,7 @@ export const tests = {
           }
         );
         // Test request internal status code is present
+        // eslint-disable-next-line @typescript-eslint/no-unused-expressions
         assert.deepEqual;
         assert.deepStrictEqual(env.ai.lastRequestInternalStatusCode, 1001);
       }
@@ -161,7 +162,7 @@ export const tests = {
         async () => {
           const arr = [1, 2, 3];
           const encoder = new TextEncoder();
-          const resp = await env.ai.run('readableStreamIputs', {
+          const _resp = await env.ai.run('readableStreamIputs', {
             audio: {
               body: new ReadableStream({
                 start(controller) {
@@ -195,7 +196,7 @@ export const tests = {
               controller.close();
             },
           });
-          const resp = await env.ai.run('readableStreamIputs', {
+          const _resp = await env.ai.run('readableStreamIputs', {
             audio: {
               body: stream,
               contentType: 'audio/wav',

src/cloudflare/internal/test/ai/ai-mock.js

@@ -2,16 +2,6 @@
 // Licensed under the Apache 2.0 license found in the LICENSE file or at:
 //     https://opensource.org/licenses/Apache-2.0
 
-function base64ToBlob(base64, mimeType) {
-  const binaryString = atob(base64); // Decode Base64
-  const len = binaryString.length;
-  const bytes = new Uint8Array(len);
-  for (let i = 0; i < len; i++) {
-    bytes[i] = binaryString.charCodeAt(i);
-  }
-  return new Blob([bytes], { type: mimeType });
-}
-
 export default {
   async fetch(request, env, ctx) {
     const url = new URL(request.url);
@@ -137,7 +127,7 @@ export default {
         try {
           // The AI API doesn't URL-encode the body parameter, so parse directly
           websocketData = JSON.parse(bodyParam);
-        } catch (e) {
+        } catch (_e) {
           websocketData = { inputs: {}, options: {} };
         }
       }

src/cloudflare/internal/test/d1/d1-api-test-common.js

@@ -11,7 +11,9 @@ const anything = Symbol('anything');
 const deleteAnything = (expected, actual) => {
   Object.entries(expected).forEach(([k, v]) => {
     if (v === anything) {
+      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
       delete actual[k];
+      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
       delete expected[k];
     } else if (typeof v === 'object' && typeof actual[k] === 'object') {
       deleteAnything(expected[k], actual[k]);

src/cloudflare/internal/test/images/images-api-test.js

@@ -1,7 +1,7 @@
 // Copyright (c) 2024 Cloudflare, Inc.
 // Licensed under the Apache 2.0 license found in the LICENSE file or at:
 //     https://opensource.org/licenses/Apache-2.0
-// @ts-ignore
+// @ts-expect-error - no type declarations for node:assert in this context
 import * as assert from 'node:assert';
 
 const encoder = new TextEncoder();

src/cloudflare/internal/test/images/images-upstream-mock.js

@@ -180,7 +180,7 @@ export class ServiceEntrypoint extends WorkerEntrypoint {
         /** @type {any} */
         const obj = {
           image: await imageAsString(form.get('image')),
-          // @ts-ignore
+          // @ts-expect-error - form.get() returns FormDataEntryValue which is not assignable to string
           transforms: JSON.parse(form.get('transforms') || '{}'),
         };
         for (const x of [

src/cloudflare/internal/test/pipeline-transform/transform-test.js

@@ -1,3 +1,4 @@
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-nocheck
 // Copyright (c) 2024 Cloudflare, Inc.
 // Licensed under the Apache 2.0 license found in the LICENSE file or at:

src/cloudflare/internal/test/vectorize/vectorize-api-test.js

@@ -2,7 +2,7 @@
 // Licensed under the Apache 2.0 license found in the LICENSE file or at:
 //     https://opensource.org/licenses/Apache-2.0
 
-// @ts-ignore
+// @ts-expect-error - no type declarations for node:assert in this context
 import * as assert from 'node:assert';
 import { KnownModel, DistanceMetric } from 'cloudflare:vectorize';
 

src/cloudflare/internal/test/vectorize/vectorize-mock.js

@@ -196,7 +196,7 @@ export default {
       }
     } catch (err) {
       return Response.json(
-        // @ts-ignore
+        // @ts-expect-error - err is typed as unknown but has message and stack
         { error: err.message, stack: err.stack },
         { status: 500 }
       );