Skip to content

CFE-3041: testall should fail a regular acceptance test if it prints errors #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarakthon wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

CFE-3041: testall should fail a regular acceptance test if it prints errors #6224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/acceptance/testall
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,8 +618,14 @@ export CFENGINE_TEST_OVERRIDE_WORKDIR TEMP CFENGINE_TEST_OVERRIDE_EXTENSION_LIBR
fi
elif egrep "R: .*$ESCAPED_TEST Pass" $OUTFILE > /dev/null
then
RESULT=Pass
RESULT_MSG="${COLOR_SUCCESS}Pass${COLOR_NORMAL}"
if egrep "error: " $OUTFILE > /dev/null
then
RESULT=FAIL
RESULT_MSG="${COLOR_FAILURE}FAIL (Test passed, but printed error message(s))${COLOR_NORMAL}"
else
RESULT=Pass
RESULT_MSG="${COLOR_SUCCESS}Pass${COLOR_NORMAL}"
fi
elif egrep "R: .*$ESCAPED_TEST Skip/unsupported" $OUTFILE > /dev/null
then
RESULT=Skip
Expand Down
Loading