Skip to content

Update Context Constructor #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TApplencourt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Context Constructor #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions include/simsycl/sycl/context.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ class context final : public detail::reference_type<context, detail::context_sta
explicit context(
const std::vector<device> &device_list, async_handler async_handler, const property_list &prop_list = {});

explicit context(const platform &plat, const property_list &prop_list = {});

explicit context(
const platform &plat, async_handler async_handler, const property_list &prop_list = {});

backend get_backend() const noexcept { return backend::simsycl; }

platform get_platform() const;
Expand Down
11 changes: 10 additions & 1 deletion src/simsycl/context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include "simsycl/sycl/context.hh"
#include "simsycl/sycl/device.hh"
#include "simsycl/sycl/exception.hh"
#include "simsycl/sycl/info.hh"
#include "simsycl/sycl/platform.hh"
#include "simsycl/system.hh"
Expand Down Expand Up @@ -44,7 +45,9 @@ struct context_state {
};

sycl::platform get_common_platform(const std::vector<sycl::device> &devices) {
SIMSYCL_CHECK(!devices.empty()); // TODO throw instead
if(devices.empty()) {
throw sycl::exception(sycl::errc::invalid, "sycl::context: device list must not be empty");
}
const auto common = devices[0].get_platform();
for(size_t i = 1; i < devices.size(); ++i) { SIMSYCL_CHECK(devices[i].get_platform() == common); }
return common;
Expand Down Expand Up @@ -77,6 +80,12 @@ context::context(const std::vector<device> &device_list, const property_list &pr
context::context(const std::vector<device> &device_list, async_handler async_handler, const property_list &prop_list)
: context(internal, device_list, async_handler, prop_list) {}

context::context(const platform &plat, const property_list &prop_list)
: context(internal, plat.get_devices(), {}, prop_list) {}

context::context(const platform &plat, async_handler async_handler, const property_list &prop_list)
: context(internal, plat.get_devices(), async_handler, prop_list) {}

template<>
platform context::get_info<info::context::platform>() const {
return state().platform;
Expand Down
Loading