Skip to content

fix: add tmpVolume support to brainstore reader and writer #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wadhah mahrouk (wadhah101) wants to merge 1 commit into
base: jeff/security-enhancements
Choose a base branch
from
Open

fix: add tmpVolume support to brainstore reader and writer #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions braintrust/examples/google-autopilot-cel/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ brainstore:
drop:
- ALL

# Required when readOnlyRootFilesystem is true — mounts a writable emptyDir at /tmp
tmpVolume:
enabled: true
sizeLimit: "1Gi"

volume:
# Requests a local SSD from GKE Autopilot via ephemeral-storage resource request
size: "1000Gi"
Expand Down Expand Up @@ -131,6 +136,11 @@ brainstore:
drop:
- ALL

# Required when readOnlyRootFilesystem is true — mounts a writable emptyDir at /tmp
tmpVolume:
enabled: true
sizeLimit: "1Gi"

volume:
size: "1000Gi"
sizeLimit: "900Gi"
Expand Down
13 changes: 13 additions & 0 deletions braintrust/templates/brainstore-reader-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ spec:
volumeMounts:
- name: cache-volume
mountPath: {{ .Values.brainstore.reader.cacheDir }}
{{- if .Values.brainstore.reader.tmpVolume.enabled }}
- name: tmp-volume
mountPath: /tmp
{{- end }}
{{- if and (eq .Values.cloud "azure") .Values.azure.enableAzureKeyVaultDriver }}
- name: secrets-store-inline
mountPath: "/mnt/secrets-store"
Expand All @@ -163,6 +167,15 @@ spec:
{}
{{- end }}
{{- end }}
{{- if .Values.brainstore.reader.tmpVolume.enabled }}
- name: tmp-volume
emptyDir:
{{- if .Values.brainstore.reader.tmpVolume.sizeLimit }}
sizeLimit: {{ .Values.brainstore.reader.tmpVolume.sizeLimit | quote }}
{{- else }}
{}
{{- end }}
{{- end }}
{{- if and (eq .Values.cloud "azure") .Values.azure.enableAzureKeyVaultDriver }}
- name: secrets-store-inline
csi:
Expand Down
13 changes: 13 additions & 0 deletions braintrust/templates/brainstore-writer-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ spec:
volumeMounts:
- name: cache-volume
mountPath: {{ .Values.brainstore.writer.cacheDir }}
{{- if .Values.brainstore.writer.tmpVolume.enabled }}
- name: tmp-volume
mountPath: /tmp
{{- end }}
{{- if and (eq .Values.cloud "azure") .Values.azure.enableAzureKeyVaultDriver }}
- name: secrets-store-inline
mountPath: "/mnt/secrets-store"
Expand All @@ -163,6 +167,15 @@ spec:
{}
{{- end }}
{{- end }}
{{- if .Values.brainstore.writer.tmpVolume.enabled }}
- name: tmp-volume
emptyDir:
{{- if .Values.brainstore.writer.tmpVolume.sizeLimit }}
sizeLimit: {{ .Values.brainstore.writer.tmpVolume.sizeLimit | quote }}
{{- else }}
{}
{{- end }}
{{- end }}
{{- if and (eq .Values.cloud "azure") .Values.azure.enableAzureKeyVaultDriver }}
- name: secrets-store-inline
csi:
Expand Down
14 changes: 11 additions & 3 deletions braintrust/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ api:
# drop:
# - ALL
# Temporary directory configuration (needed when readOnlyRootFilesystem is true)
# tmpVolume:
# enabled: true
# sizeLimit: "1Gi"
tmpVolume:
enabled: false
# sizeLimit: "1Gi"
# Allow running user generated code functions (e.g. scorers/tools)
allowCodeFunctionExecution: true
# Brainstore backfill configuration. These defaults are fine for most cases.
Expand Down Expand Up @@ -235,6 +235,10 @@ brainstore:
# capabilities:
# drop:
# - ALL
# Temporary directory configuration (needed when readOnlyRootFilesystem is true)
tmpVolume:
enabled: false
# sizeLimit: "1Gi"
cacheDir: "/mnt/tmp/brainstore"
objectStoreCacheMemoryLimit: "1Gi"
objectStoreCacheFileSize: "50Gi"
Expand Down Expand Up @@ -287,6 +291,10 @@ brainstore:
# capabilities:
# drop:
# - ALL
# Temporary directory configuration (needed when readOnlyRootFilesystem is true)
tmpVolume:
enabled: false
# sizeLimit: "1Gi"
cacheDir: "/mnt/tmp/brainstore"
objectStoreCacheMemoryLimit: "1Gi"
objectStoreCacheFileSize: "50Gi"
Expand Down