fix: add tmpVolume support to brainstore reader and writer#74
Open
wadhah mahrouk (wadhah101) wants to merge 1 commit intobraintrustdata:jeff/security-enhancementsfrom
Open
Conversation
wadhah mahrouk (wadhah101)
changed the base branch from
main
to
jeff/security-enhancements
wadhah mahrouk (wadhah101)
changed the title
wadhah mahrouk (wadhah101)
changed the title
Add tmpVolume configuration for brainstore reader and writer deployments, matching the existing API tmpVolume pattern. This mounts a writable emptyDir at /tmp, which is required when readOnlyRootFilesystem is enabled for CEL policy compliance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
wadhah mahrouk (wadhah101)
force-pushed
the
jeff/brainstore-tmp-volume
branch
from
813f1f3 to
fc439e6
Compare
wadhah mahrouk (wadhah101)
changed the title
Hedi Daoud (hdaoud23)
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmpVolumeconfiguration to brainstore reader and writer deployments, matching the existing APItmpVolumepatternemptyDirat/tmp— required whenreadOnlyRootFilesystemistruefor CEL policy compliancetmpVolumedefaults: changed all threetmpVolumeconfigs (API, reader, writer) from fully commented-out to actual default values (enabled: false), preventing template rendering failures whentmpVolumeis not explicitly settmpVolumefor both brainstore reader and writerThe
require-readonly-root-filesystemCEL policy requires all containers to use read-only root filesystems. When enabled, processes that write to/tmpfail unless a writable volume is mounted there. The API deployment already had this feature; this PR extends it to brainstore reader and writer.Changes
braintrust/values.yaml— AddedtmpVolumedefaults (enabled: false) underapi,brainstore.reader, andbrainstore.writer(previously fully commented out, which caused nil pointer errors duringhelm template)braintrust/templates/brainstore-reader-deployment.yaml— Added conditionaltmp-volumevolumeMount and volumebraintrust/templates/brainstore-writer-deployment.yaml— Added conditionaltmp-volumevolumeMount and volumebraintrust/examples/google-autopilot-cel/values.yaml— EnabledtmpVolumefor both reader and writer in the CEL exampleHow to test
helm templatewith default values renders without errors and excludestmp-volumehelm template --set brainstore.writer.tmpVolume.enabled=true --set brainstore.writer.tmpVolume.sizeLimit=1Giincludes the/tmpmount and emptyDir volume with sizeLimithelm template -f examples/google-autopilot-cel/values.yamlrenders both reader and writer withtmp-volumecorrectly