Wait for spans to become available before we run getThread/getSpans#1670
Wait for spans to become available before we run getThread/getSpans#1670Alex Z (CLowbrow) wants to merge 10 commits intomainfrom
Conversation
john (j13huang)
left a comment
john (j13huang)
left a comment
There was a problem hiding this comment.
quick thoughts, glad it seems to be not crazy
js/src/logger.ts
Outdated
| } | ||
| const lastXactId = extractLastXactIdFromLogs3Response(response); | ||
| if (lastXactId) { | ||
| this._lastFlushedXactId = lastXactId; |
There was a problem hiding this comment.
prob want to take the max id. There's a strMax function somewhere
There was a problem hiding this comment.
I can't find the shared function but did change this behavior
|
|
||
| const callback = async (rootSpan: Span) => { | ||
| const state = evaluator.state ?? _internalGetGlobalState(); | ||
| const state = |
There was a problem hiding this comment.
probably want to verify this work for playgrounds also
There was a problem hiding this comment.
Works in playgrounds locally, we probably want to push this to staging to check though
| const parentComponents = parentStr | ||
| ? SpanComponentsV3.fromStr(parentStr) | ||
| : null; | ||
| const xactId = state?.bgLogger().lastFlushedXactId(); |
There was a problem hiding this comment.
want to double check this works in otel land
There was a problem hiding this comment.
It does not :(
| const callback = async (rootSpan: Span) => { | ||
| const state = evaluator.state ?? _internalGetGlobalState(); | ||
| const state = | ||
| experiment?.loggingState ?? |
There was a problem hiding this comment.
this now modifies the state variable so we should make sure that it works properly in the downstream callsites for state = experiment?.loggingState
2 participants
No description provided.