ci: Split up network fetches and retry with Justfile targets#2187
Open
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Open
ci: Split up network fetches and retry with Justfile targets#2187cgwalters wants to merge 1 commit intobootc-dev:mainfrom
cgwalters wants to merge 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the image provisioning process by splitting it into two distinct stages: a network-dependent 'fetch' stage and a network-isolated 'configure' stage. This change allows for independent retries of network-heavy operations via a new 'build-fetch' command in the Justfile, improving CI reliability against transient failures. A logic error was identified in the new 'provision-configure.sh' script where the root user's configuration was being deleted immediately after creation due to the order of operations and the use of symbolic links for the home directory.
Our CI is long and flakes are painful, especially with merge queues. Let's take a heavy hammer and refactor all network-fetched resources into a clearly separate stage, and then we have a fully enforced retry loop for those that has even longer timeouts in CI. Assisted-by: OpenCode (claude-sonnet-4-6@default) Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
provisioning-retries
branch
from
c03b509 to
43b67e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CI is long and flakes are painful, especially with merge queues. Let's take a heavy hammer and refactor all network-fetched resources into a clearly separate stage, and then we have a fully enforced retry loop for those that has even longer timeouts in CI.
Assisted-by: OpenCode (claude-sonnet-4-6@default)