Skip to content

docs(wallet): fix misleading RBF comment in create_tx #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValuedMammal merged 1 commit into from
Apr 14, 2026
Merged

docs(wallet): fix misleading RBF comment in create_tx #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/wallet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1492,10 +1492,10 @@ impl Wallet {

if tx.output.is_empty() {
// Uh oh, our transaction has no outputs.
// We allow this when:
// - We have a drain_to address and the utxos we must spend (this happens,
// for example, when we RBF).
// - We have a drain_to address and drain_wallet set.
// We allow this when we have a `drain_to` address and either:
// - `drain_wallet` is enabled
// - there are UTXOs we must spend (this happens, for example, when
// sweeping specific UTXOs to a given address)
Comment thread
va-an marked this conversation as resolved.
// Otherwise, we don't know who we should send the funds to, and how much
// we should send!
if params.drain_to.is_some() && (params.drain_wallet || !params.utxos.is_empty()) {
Expand Down