Skip to content

docs(wallet): fix misleading RBF comment in create_tx#422

Open
va-an wants to merge 1 commit intobitcoindevkit:masterfrom
va-an:docs/fix-create-tx-empty-outputs
Open

docs(wallet): fix misleading RBF comment in create_tx#422
va-an wants to merge 1 commit intobitcoindevkit:masterfrom
va-an:docs/fix-create-tx-empty-outputs

Conversation

@va-an
Copy link
Copy Markdown

@va-an va-an commented Mar 27, 2026

Description

Closes: #45

Changelog notice

Fixed:

  • Fix docs for Wallet:create_tx when empty output vector

Checklists

All Submissions:

- Replace incorrect RBF example with sweeping UTXOs
- Reorder comment items to match the code's condition order
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.04%. Comparing base (4e202c8) to head (62409a5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files          24       24           
  Lines        5336     5336           
  Branches      242      242           
=======================================
  Hits         4271     4271           
  Misses        987      987           
  Partials       78       78           
Flag Coverage Δ
rust 80.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValuedMammal ValuedMammal moved this to Needs Review in BDK Wallet Mar 30, 2026
@ValuedMammal ValuedMammal added this to the Wallet 3.1.0 milestone Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

Fix docs for Wallet:create_tx when empty output vector

2 participants