ci: run some Bitcoin Core CI jobs by Sjors · Pull Request #253 · bitcoin-core/libmultiprocess

Sjors · 2026-03-11T16:26:15Z

Slightly more elaborate version of #252 with ccache and depends caching.

Sjors · 2026-03-11T16:31:10Z

@ryanofsky can you expand the whitelist with actions/cache@* and actions/cache/*@*?

(that's what's causing the new workflows to get ignored, see annotations here: https://github.com/bitcoin-core/libmultiprocess/actions/runs/22963039475)

DrahtBot · 2026-03-11T16:31:15Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	ryanofsky

If your review is incorrectly listed, please copy-paste  into the comment that the bot should ignore.

Sjors · 2026-03-11T18:51:46Z

Thanks, the jobs run now, I'll debug them later.

.github/workflows/bitcoin-core-ci.yml

maflcko · 2026-03-12T12:10:15Z

.github/workflows/bitcoin-core-ci.yml

+
+      - name: Run IPC and miner unit tests
+        run: |
+          ctest --test-dir build -R "ipc|miner_tests" --output-on-failure --timeout 480


same. Also could use the longer --tests-regex instead of -R to be more self-explanatory?

maflcko · 2026-03-12T12:12:45Z

.github/workflows/bitcoin-core-ci.yml

+          sudo apt-get install --no-install-recommends -y ${{ matrix.packages }}
+          sudo update-alternatives --install /usr/bin/clang++ clang++ "/usr/bin/clang++-${LLVM_VERSION}" 100
+          sudo update-alternatives --install /usr/bin/clang clang "/usr/bin/clang-${LLVM_VERSION}" 100
+          sudo update-alternatives --install /usr/bin/llvm-symbolizer llvm-symbolizer "/usr/bin/llvm-symbolizer-${LLVM_VERSION}" 100


I wonder if we can split the upstream install script into smaller re-useable bash or python scripts, to be used here?

I'm not sure about trying to expose bash scripts as a sort of stable CI API, which would essentially give us an undocumented and untested consumer. Inevitably, changes in our repo will break things, and we'll have another loop of having to re-refactor/change, based on requirements here, that nobody in our repository is accounting for when making changes there.

In general we'll need to wait and see if these Bitcoin Core jobs are maintainable here over the long run. If it becomes more hassle that just opening a draft PR on bitcoin/bitcoin then we might just drop them.

Sjors · 2026-03-12T12:53:56Z

All green. Pushed again to wire up ccache.

maflcko · 2026-03-12T14:40:35Z

all green

Well, then this is obviously wrong, because it fails to find any of the countless bugs that still exist.

It would be good to find at least one of them. Otherwise, this seems pointless?

Sjors · 2026-03-12T15:25:17Z

@maflcko this doesn't include #250 so might not catch those?

fanquake · 2026-03-12T15:27:23Z

this doesn't include #250 so might not catch those?

If it doesn't include #250, then shouldn't it catch all the bugs being fixed by #250? (or any of the others that exist with #250 included, bitcoin/bitcoin#34804 (comment), assuming they don't require #250 to be merged).

Sjors · 2026-03-12T15:32:01Z

@fanquake the test hooks added in #250 make it more likely to find those bugs in the first place. They all made it through CI initially. But as a sanity check it could make sense if I add those tests here (without fixes).

.github/workflows/bitcoin-core-ci.yml

maflcko · 2026-03-12T15:47:44Z

@fanquake the test hooks added in #250 make it more likely to find those bugs in the first place. They all made it through CI initially. But as a sanity check it could make sense if I add those tests here (without fixes).

I think it makes more sense to try to find the bugs without the new tests. The goal here isn't to catch bugs in newly added deterministic tests, but to catch intermittent bugs in the vanilla (pre-existing) subtree.

Sjors · 2026-03-12T16:12:47Z

I added a third commit for tweaking the frequencies. All three jobs now run the unit and functional tests 200 times.

Sjors · 2026-03-12T16:32:59Z

Test run times:

macOS: unit 4s, functional ?s
TSAN: unit 15s, functional ?s
ASan / UBSan: unit 10s, functional ?s

Unit tests are still running, from previous experience the functional tests took about 1 second each.

I'd like to keep the job runtimes under 15 minutes:

olddeps is the slowest, takes about 10 minutes
gnu32 currently takes 1+ hour, but hopefully ci: cache gnu32 nix store #256 speeds it up

Assuming 3 minutes for setup, 4 minutes for unit tests and 4 minutes for functional tests, I'll tweak the numbers.

(also forgot to install ccache on macOS)

maflcko · 2026-03-12T16:44:50Z

nice. Let's hope one of them fails 😅

maflcko · 2026-03-12T16:47:57Z

ok, none failed :(

Sjors · 2026-03-12T16:49:47Z

I'm lowering the unit tests a bit. Also noticed I forgot to run the _miner.py test 🤡

.github/workflows/bitcoin-core-ci.yml

maflcko · 2026-03-12T19:03:21Z

.github/workflows/bitcoin-core-ci.yml

+        run: |
+          for _ in $(seq 1 "${TSAN_FUNCTIONAL_TEST_RUNS}"); do
+            LD_LIBRARY_PATH="depends/${{ steps.host.outputs.host }}/lib" \
+            build/test/functional/test_runner.py --filter='^interface_ipc' --jobs "${PARALLEL}" --timeout-factor=10


there are only two tests, so the --jobs PARALLEL won't make any difference, also this is running sequentially over TSAN_FUNCTIONAL_TEST_RUNS

Maybe the GHA machines just won't trigger the failures here?

Has anyone reproduced any of the failures locally, when running the tests?

Yeah, I got confused there. You can't use --filter to run tests multiple times, you have to pass the names in multiple times. The latest push should fix this.

(well, the next push...)

Sjors · 2026-03-24T10:58:25Z

It seems to me the overall CI setup could be substantially simplified with some basic bash scripting. There should be no need to copy long command lines multiple times in yaml files when bash is a scripting language that supports functions, and it should be easy to write a bash script exposing high level hooks for the yaml to call.

Agreed, done.

git diff 746beea HEAD --color-moved=dimmed-zebra

There's a few one-liners that might not worthy of a function (e.g. show_ccache_stats), but typically there's a related function that's larger (reset_ccache_stats) and it seems better to keep those in one place.

ad75b14 test: scale IPC mining wait timeouts by timeout_factor (Enoch Azariah) e7a918b test: verify IPC error handling for invalid coinbase (Enoch Azariah) 63684d6 test: move make_mining_ctx to ipc_util.py (Enoch Azariah) 4ada575 test: verify createNewBlock wakes promptly when tip advances (Enoch Azariah) Pull request description: This is a follow-up to implement a couple of test improvements discussed in recent IPC PRs and issues. - adds a test to `interface_ipc_mining.py` to verify that `createNewBlock` wakes up immediately when the tip advances, rather than waiting for the cooldown timer to expire (#34184 (comment)). - moves `make_mining_ctx` into `ipc_util.py` so it can be reused across the IPC tests instead of duplicating the setup code (#34422 (comment)). - adds a test case to verify that providing an invalid coinbase to `submitSolution` returns a remote exception instead of crashing the node, closing the loop on the issue reported in #33341. - scales IPC wait timeouts using the test suite's `timeout_factor` to prevent spurious failures in heavily loaded CI environments, capping extended waits to avoid test runner hangs (bitcoin-core/libmultiprocess#253 (comment)). Closes #33341. ACKs for top commit: Sjors: ACK ad75b14 achow101: ACK ad75b14 sedited: ACK ad75b14 Tree-SHA512: 812aa64c03657761f06707e6a15b8b435ab7c75717a6748a919fcbcae317128e18403b0c1bddd4cdad877d286e69db52389633e4012faaa656acc01939091719

The IPC mining tests (interface_ipc_mining.py) currently use hardcoded timeouts (e.g., 1000ms, 60000ms) for operations like waitTipChanged and waiting for block templates. In heavily loaded CI environments, such as those running sanitizers with high parallelism, these hardcoded timeouts can be too short, leading to spurious test failures and brittleness. This commit multiplies these timeout variables by the test suite's global `self.options.timeout_factor`. This ensures that the IPC wait conditions scale appropriately when the test suite is run with a higher timeout factor, making the tests robust against slow execution environments. Addresses CI brittleness observed in bitcoin-core/libmultiprocess#253. Github-Pull: bitcoin#34727 Rebased-From: ad75b14

ryanofsky

Light code review ACK 55a9b55. I looked at all the code here and confirmed it should be safe and the build steps make sense. But did not look closely enough to follow all the internal logic and be very sure there aren't bugs.

Thanks for factoring out the command lines into bash functions! IMO the jobs are much easier to understand now.

I probably would have gone further and moved configuration of the jobs as well to bash in /ci/configs/. And instead of defining lower-level bash hooks like add_llvm_apt_repository, install_apt_packages, install_llvm_alternatives I would have defined higher level-hooks like install_deps. But the current approach seems reasonable too.

As a followup, it might be good if bitcoin core CI could follow the model of this PR and move its low-level command lines into libraries like ci_helpers.sh and bitcoin_core_ci.sh. If it did this we might be able to delete this code entirely from the libmultiprocess repository and just call the bitcoin core definitions.

Alternately, maybe the approach marco originally suggested in #250 (comment) which invokes bitcoin core's github actions could work. I'm not sure if there was a specific reason this PR did not take that approach.

maflcko · 2026-03-25T16:09:00Z

As a followup, it might be good if bitcoin core CI could follow the model of this PR and move its low-level command lines into libraries like ci_helpers.sh and bitcoin_core_ci.sh. If it did this we might be able to delete this code entirely from the libmultiprocess repository and just call the bitcoin core definitions.

Bitcoin Core already does this. You can call (let's say) env -i HOME="$HOME" PATH="$PATH" USER="$USER" FILE_ENV="./ci/test/00_setup_env_arm.sh" ./ci/test_run_all.sh, where FILE_ENV denotes the config and the run script will run the CI.

Alternately, maybe the approach marco originally suggested in #250 (comment) which invokes bitcoin core's github actions could work. I'm not sure if there was a specific reason this PR did not take that approach.

I think there is no hook for replace_subtree and no hook for for _ in $(seq 1 "${runs}"); do and the cache will be less fine-grained, but it should be possible to add those.

ryanofsky · 2026-03-25T16:51:17Z

So it sounds like this PR were modified to call bitcoin core's test_run_all.sh or call its github actions, it might lose the ability to:

Run ipc tests repeatedly
Skip bitcoin core tests not related to IPC
Have fine-grained caching

(1) and (2) do seem pretty useful and not having (3) seems like it could be a major drawback if every libmultiprocess change broke the depends cache and required depends rebuilds, but unclear if that would happen. In any case, it sound like it might be easier to modify bitcoin core's ci to support these things than I initially though.

Sjors · 2026-03-25T17:42:41Z

One advantage of moving towards the Bitcoin Core approach of doing ~everything with bash scripts, is that it's more CI agnostic.

maflcko · 2026-03-26T12:21:57Z

So it sounds like this PR were modified to call bitcoin core's test_run_all.sh or call its github actions, it might lose the ability to:
1. Run ipc tests repeatedly

2. Skip bitcoin core tests not related to IPC

3. Have fine-grained caching
(1) and (2) do seem pretty useful and not having (3) seems like it could be a major drawback if every libmultiprocess change broke the depends cache and required depends rebuilds, but unclear if that would happen. In any case, it sound like it might be easier to modify bitcoin core's ci to support these things than I initially though.

I think they are all supported already:

There is a TEST_RUNNER_EXTRA= flag, which can be set to TEST_RUNNER_EXTRA=$(python3 -c "import sys; import os; sys.path.append(os.path.abspath('build/test/functional')); from test_runner import ALL_SCRIPTS; print(' '.join(s for s in ALL_SCRIPTS if s.startswith('interface_ipc')))"), possibly repeated
There is no equivalent flag for ctest, but it should be trivial to add it in a one-line patch
The caching can be controlled via DANGER_CI_ON_HOST_FOLDERS, which exposes a folder for each cache

Not sure if there is a hook for replace_subtree, or if this can be added with a trivial one-line patch.

…bf18 ff0eed1bf18 refactor: Use loop variable in type-context.h ff1d8ba172a refactor: Move type-context.h getParams() call closer to use 1dbc59a4aa3 race fix: m_on_cancel called after request finishes 1643d05ba07 test: m_on_cancel called after request finishes f5509a31fcc race fix: getParams() called after request cancel 4a60c39f24a test: getParams() called after request cancel f11ec29ed20 race fix: worker thread destroyed before it is initialized a1d643348f4 test: worker thread destroyed before it is initialized e606fd84a8c Merge bitcoin-core/libmultiprocess#264: ci: reduce nproc multipliers 336023382c4 ci: reduce nproc multipliers b090beb9651 Merge bitcoin-core/libmultiprocess#256: ci: cache gnu32 nix store be8622816da ci: cache gnu32 nix store 975270b619c Merge bitcoin-core/libmultiprocess#263: ci: bump timeout factor to 40 09f10e5a598 ci: bump timeout factor to 40 db8f76ad290 Merge bitcoin-core/libmultiprocess#253: ci: run some Bitcoin Core CI jobs 55a9b557b19 ci: set Bitcoin Core CI test repetition fb0fc84d556 ci: add TSan job with instrumented libc++ 0f29c38725b ci: add Bitcoin Core IPC tests (ASan + macOS) 3f64320315d Merge bitcoin-core/libmultiprocess#262: ci: enable clang-tidy in macOS job, use nullptr cd9f8bdc9f0 Merge bitcoin-core/libmultiprocess#258: log: add socket connected info message and demote destroy logs to debug b5d6258a42f Merge bitcoin-core/libmultiprocess#255: fix: use unsigned char cast and sizeof in LogEscape escape sequence d94688e2c32 Merge bitcoin-core/libmultiprocess#251: Improved CustomBuildField for std::optional in IPC/libmultiprocess a9499fad755 mp: use nullptr with pthread_threadid_np f499e37850f ci: enable clang-tidy in macOS job 98f1352159d log: add socket connected info message and demote destroy logs to debug 554a481ea73 fix: use unsigned char cast and sizeof in LogEscape escape sequence 1977b9f3f65 Use std::forward in CustomBuildField for std::optional to allow move semantics, resolves FIXME 22bec918c97 Merge bitcoin-core/libmultiprocess#247: type-map: Work around LLVM 22 "out of bounds index" error 8a5e3ae6ed2 Merge bitcoin-core/libmultiprocess#242: proxy-types: add CustomHasField hook to map Cap'n Proto values to null C++ values e8d35246918 Merge bitcoin-core/libmultiprocess#246: doc: Bump version 8 > 9 97d877053b6 proxy-types: add CustomHasField hook for nullable decode paths 8c2f10252c9 refactor: add missing includes to mp/type-data.h b1638aceb40 doc: Bump version 8 > 9 f61af487217 type-map: Work around LLVM 22 "out of bounds index" error git-subtree-dir: src/ipc/libmultiprocess git-subtree-split: ff0eed1bf183627c89007e71d631f039bd61bfb5

ryanofsky · 2026-03-26T14:02:24Z

Hopefully this is the last CI headache to resolve, but the bitcoin core linter wants LC_ALL to be set in bash scripts added here:

Missing "export LC_ALL=C" (to avoid locale dependence) as first non-comment non-empty line in src/ipc/libmultiprocess/ci/scripts/bitcoin_core_ci.sh
Missing "export LC_ALL=C" (to avoid locale dependence) as first non-comment non-empty line in src/ipc/libmultiprocess/ci/scripts/ci_helpers.sh
Missing "export LC_ALL=C" (to avoid locale dependence) as first non-comment non-empty line in src/ipc/libmultiprocess/ci/scripts/config.sh

https://github.com/bitcoin/bitcoin/actions/runs/23598079789/job/68720184763?pr=34804

Sjors · 2026-03-26T15:33:17Z

Fixed in #265.

…bf18 ff0eed1bf18 refactor: Use loop variable in type-context.h ff1d8ba172a refactor: Move type-context.h getParams() call closer to use 1dbc59a4aa3 race fix: m_on_cancel called after request finishes 1643d05ba07 test: m_on_cancel called after request finishes f5509a31fcc race fix: getParams() called after request cancel 4a60c39f24a test: getParams() called after request cancel f11ec29ed20 race fix: worker thread destroyed before it is initialized a1d643348f4 test: worker thread destroyed before it is initialized e606fd84a8c Merge bitcoin-core/libmultiprocess#264: ci: reduce nproc multipliers 336023382c4 ci: reduce nproc multipliers b090beb9651 Merge bitcoin-core/libmultiprocess#256: ci: cache gnu32 nix store be8622816da ci: cache gnu32 nix store 975270b619c Merge bitcoin-core/libmultiprocess#263: ci: bump timeout factor to 40 09f10e5a598 ci: bump timeout factor to 40 db8f76ad290 Merge bitcoin-core/libmultiprocess#253: ci: run some Bitcoin Core CI jobs 55a9b557b19 ci: set Bitcoin Core CI test repetition fb0fc84d556 ci: add TSan job with instrumented libc++ 0f29c38725b ci: add Bitcoin Core IPC tests (ASan + macOS) 3f64320315d Merge bitcoin-core/libmultiprocess#262: ci: enable clang-tidy in macOS job, use nullptr cd9f8bdc9f0 Merge bitcoin-core/libmultiprocess#258: log: add socket connected info message and demote destroy logs to debug b5d6258a42f Merge bitcoin-core/libmultiprocess#255: fix: use unsigned char cast and sizeof in LogEscape escape sequence d94688e2c32 Merge bitcoin-core/libmultiprocess#251: Improved CustomBuildField for std::optional in IPC/libmultiprocess a9499fad755 mp: use nullptr with pthread_threadid_np f499e37850f ci: enable clang-tidy in macOS job 98f1352159d log: add socket connected info message and demote destroy logs to debug 554a481ea73 fix: use unsigned char cast and sizeof in LogEscape escape sequence 1977b9f3f65 Use std::forward in CustomBuildField for std::optional to allow move semantics, resolves FIXME 22bec918c97 Merge bitcoin-core/libmultiprocess#247: type-map: Work around LLVM 22 "out of bounds index" error 8a5e3ae6ed2 Merge bitcoin-core/libmultiprocess#242: proxy-types: add CustomHasField hook to map Cap'n Proto values to null C++ values e8d35246918 Merge bitcoin-core/libmultiprocess#246: doc: Bump version 8 > 9 97d877053b6 proxy-types: add CustomHasField hook for nullable decode paths 8c2f10252c9 refactor: add missing includes to mp/type-data.h b1638aceb40 doc: Bump version 8 > 9 f61af487217 type-map: Work around LLVM 22 "out of bounds index" error git-subtree-dir: src/ipc/libmultiprocess git-subtree-split: ff0eed1bf183627c89007e71d631f039bd61bfb5

…da8f 70f632bda8f Merge bitcoin-core/libmultiprocess#265: ci: set LC_ALL in shell scripts 8e8e564259a Merge bitcoin-core/libmultiprocess#249: fixes for race conditions on disconnects 05d34cc2ec3 ci: set LC_ALL in shell scripts e606fd84a8c Merge bitcoin-core/libmultiprocess#264: ci: reduce nproc multipliers ff0eed1bf18 refactor: Use loop variable in type-context.h ff1d8ba172a refactor: Move type-context.h getParams() call closer to use 1dbc59a4aa3 race fix: m_on_cancel called after request finishes 1643d05ba07 test: m_on_cancel called after request finishes f5509a31fcc race fix: getParams() called after request cancel 4a60c39f24a test: getParams() called after request cancel f11ec29ed20 race fix: worker thread destroyed before it is initialized a1d643348f4 test: worker thread destroyed before it is initialized 336023382c4 ci: reduce nproc multipliers b090beb9651 Merge bitcoin-core/libmultiprocess#256: ci: cache gnu32 nix store be8622816da ci: cache gnu32 nix store 975270b619c Merge bitcoin-core/libmultiprocess#263: ci: bump timeout factor to 40 09f10e5a598 ci: bump timeout factor to 40 db8f76ad290 Merge bitcoin-core/libmultiprocess#253: ci: run some Bitcoin Core CI jobs 55a9b557b19 ci: set Bitcoin Core CI test repetition fb0fc84d556 ci: add TSan job with instrumented libc++ 0f29c38725b ci: add Bitcoin Core IPC tests (ASan + macOS) 3f64320315d Merge bitcoin-core/libmultiprocess#262: ci: enable clang-tidy in macOS job, use nullptr cd9f8bdc9f0 Merge bitcoin-core/libmultiprocess#258: log: add socket connected info message and demote destroy logs to debug b5d6258a42f Merge bitcoin-core/libmultiprocess#255: fix: use unsigned char cast and sizeof in LogEscape escape sequence d94688e2c32 Merge bitcoin-core/libmultiprocess#251: Improved CustomBuildField for std::optional in IPC/libmultiprocess a9499fad755 mp: use nullptr with pthread_threadid_np f499e37850f ci: enable clang-tidy in macOS job 98f1352159d log: add socket connected info message and demote destroy logs to debug 554a481ea73 fix: use unsigned char cast and sizeof in LogEscape escape sequence 1977b9f3f65 Use std::forward in CustomBuildField for std::optional to allow move semantics, resolves FIXME 22bec918c97 Merge bitcoin-core/libmultiprocess#247: type-map: Work around LLVM 22 "out of bounds index" error 8a5e3ae6ed2 Merge bitcoin-core/libmultiprocess#242: proxy-types: add CustomHasField hook to map Cap'n Proto values to null C++ values e8d35246918 Merge bitcoin-core/libmultiprocess#246: doc: Bump version 8 > 9 97d877053b6 proxy-types: add CustomHasField hook for nullable decode paths 8c2f10252c9 refactor: add missing includes to mp/type-data.h b1638aceb40 doc: Bump version 8 > 9 f61af487217 type-map: Work around LLVM 22 "out of bounds index" error git-subtree-dir: src/ipc/libmultiprocess git-subtree-split: 70f632bda8f80449b6240f98da768206a535a04e

…n disconnects 2478a15 Squashed 'src/ipc/libmultiprocess/' changes from 1868a84451f..70f632bda8f (Ryan Ofsky) Pull request description: Includes: - bitcoin-core/libmultiprocess#246 - bitcoin-core/libmultiprocess#242 - bitcoin-core/libmultiprocess#247 - bitcoin-core/libmultiprocess#251 - bitcoin-core/libmultiprocess#255 - bitcoin-core/libmultiprocess#258 - bitcoin-core/libmultiprocess#262 - bitcoin-core/libmultiprocess#253 - bitcoin-core/libmultiprocess#263 - bitcoin-core/libmultiprocess#256 - bitcoin-core/libmultiprocess#264 - bitcoin-core/libmultiprocess#249 - bitcoin-core/libmultiprocess#265 The main change is bitcoin-core/libmultiprocess#249 which fixes 3 intermittent race conditions detected in bitcoin core CI and antithesis: #34711/#34756, #34777, and #34782. The changes can be verified by running `test/lint/git-subtree-check.sh src/ipc/libmultiprocess` as described in [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees) and [lint instructions](https://github.com/bitcoin/bitcoin/tree/master/test/lint#git-subtree-checksh) ACKs for top commit: Sjors: ACK 613a548 ismaelsadeeq: ACK 613a548 Tree-SHA512: d99eebc8b4f45b3c3099298167362cf5e7f3e9e622eef9f17af56388ee5207d77a04b915b2a5a894493e0395aeda70111216f2da0d2a6553f4f6396b3d31a744

Sjors mentioned this pull request Mar 11, 2026

ci: run Bitcoin Core CI jobs #252

Closed

Sjors mentioned this pull request Mar 11, 2026

ci: cache nix store #254

Closed

ryanofsky closed this Mar 11, 2026

ryanofsky reopened this Mar 11, 2026

Sjors force-pushed the 2026/03/ci-core branch from 5b00ed4 to 50a7f05 Compare March 12, 2026 10:47

maflcko approved these changes Mar 12, 2026

View reviewed changes

Sjors force-pushed the 2026/03/ci-core branch 2 times, most recently from a1e0fb1 to cb8a9e8 Compare March 12, 2026 12:53

Sjors marked this pull request as ready for review March 12, 2026 13:16

maflcko reviewed Mar 12, 2026

View reviewed changes

.github/workflows/bitcoin-core-ci.yml Outdated Show resolved Hide resolved

.github/workflows/bitcoin-core-ci.yml Outdated Show resolved Hide resolved

Sjors force-pushed the 2026/03/ci-core branch from cb8a9e8 to 1c25227 Compare March 12, 2026 16:12

Sjors force-pushed the 2026/03/ci-core branch from 1c25227 to 8c562fe Compare March 12, 2026 16:19

Sjors force-pushed the 2026/03/ci-core branch from 8c562fe to f03e3a2 Compare March 12, 2026 16:33

maflcko reviewed Mar 12, 2026

View reviewed changes

.github/workflows/bitcoin-core-ci.yml Outdated Show resolved Hide resolved

Sjors force-pushed the 2026/03/ci-core branch from f03e3a2 to 65abbaf Compare March 12, 2026 18:36

maflcko reviewed Mar 12, 2026

View reviewed changes

ci: add Bitcoin Core IPC tests (ASan + macOS)

0f29c38

Sjors force-pushed the 2026/03/ci-core branch from 746beea to 7c47cf8 Compare March 24, 2026 10:43

Sjors marked this pull request as draft March 24, 2026 10:44

Sjors added 2 commits March 24, 2026 11:53

ci: add TSan job with instrumented libc++

fb0fc84

ci: set Bitcoin Core CI test repetition

55a9b55

Sjors force-pushed the 2026/03/ci-core branch from 7c47cf8 to 55a9b55 Compare March 24, 2026 10:55

Sjors mentioned this pull request Mar 24, 2026

ci: cache gnu32 nix store #256

Merged

Sjors marked this pull request as ready for review March 24, 2026 11:29

This was referenced Mar 25, 2026

test: Add IPC wake-up test and reuse mining context (PR #34727) - Follow-up 1 of 2 kevkevinpal/bitcoin#315

Open

test: Add IPC wake-up test and reuse mining context (PR #34727) - Follow-up 2 of 2 kevkevinpal/bitcoin#316

Open

ryanofsky approved these changes Mar 25, 2026

View reviewed changes

ryanofsky merged commit db8f76a into bitcoin-core:master Mar 25, 2026
13 checks passed

Sjors deleted the 2026/03/ci-core branch March 25, 2026 17:27

ryanofsky mentioned this pull request Mar 26, 2026

Update libmultiprocess subtree to fix race conditions on disconnects bitcoin/bitcoin#34804

Merged

ryanofsky mentioned this pull request Mar 27, 2026

ci: subtree lint scope bitcoin/bitcoin#34928

Open

ryanofsky mentioned this pull request Mar 30, 2026

Update libmultiprocess subtree in 31.x branch to fix race conditions on disconnects bitcoin/bitcoin#34952

Open

Conversation

Sjors commented Mar 11, 2026

Uh oh!

Sjors commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Uh oh!

Sjors commented Mar 11, 2026

Uh oh!

Uh oh!

maflcko Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

maflcko Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

fanquake Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Sjors Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Sjors commented Mar 12, 2026

Uh oh!

maflcko commented Mar 12, 2026

Uh oh!

Sjors commented Mar 12, 2026

Uh oh!

fanquake commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sjors commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maflcko commented Mar 12, 2026

Uh oh!

Sjors commented Mar 12, 2026

Uh oh!

Sjors commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Mar 12, 2026

Uh oh!

maflcko commented Mar 12, 2026

Uh oh!

Sjors commented Mar 12, 2026

Uh oh!

Uh oh!

maflcko Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Sjors Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sjors commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryanofsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maflcko commented Mar 25, 2026

Uh oh!

ryanofsky commented Mar 25, 2026

Uh oh!

Sjors commented Mar 25, 2026

Uh oh!

maflcko commented Mar 26, 2026

Uh oh!

ryanofsky commented Mar 26, 2026

Uh oh!

Sjors commented Mar 26, 2026

Uh oh!

Reviewers

Sjors commented Mar 11, 2026 •

edited

Loading

DrahtBot commented Mar 11, 2026 •

edited

Loading

fanquake commented Mar 12, 2026 •

edited

Loading

Sjors commented Mar 12, 2026 •

edited

Loading

Sjors commented Mar 12, 2026 •

edited

Loading

Sjors Mar 12, 2026 •

edited

Loading

Sjors commented Mar 24, 2026 •

edited

Loading