Skip to content

ci: run Bitcoin Core CI jobs#252

Closed
ryanofsky wants to merge 1 commit intobitcoin-core:masterfrom
ryanofsky:pr/coreci
Closed

ci: run Bitcoin Core CI jobs#252
ryanofsky wants to merge 1 commit intobitcoin-core:masterfrom
ryanofsky:pr/coreci

Conversation

@ryanofsky
Copy link
Copy Markdown
Collaborator

Add a workflow that runs Bitcoin Core CI jobs against libmultiprocess by overlaying the repository into the bitcoin/src/ipc/libmultiprocess subtree during CI.

Approach suggested by maflcko #250 (comment)

Add a workflow that runs Bitcoin Core CI jobs against libmultiprocess
by overlaying the repository into the bitcoin/src/ipc/libmultiprocess
subtree during CI.
@DrahtBot
Copy link
Copy Markdown

DrahtBot commented Mar 11, 2026

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Mar 11, 2026

Oh I was about to open one too, see #253.

@ryanofsky
Copy link
Copy Markdown
Collaborator Author

Oh I was about to open one too, see #253.

Thanks! I'm happy to go with your version. It seems like the workflows are just being ignored though? Not sure if you have any ideas to debug

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Mar 11, 2026

Looks like the CI jobs here also (like in #253) get skipped because they're using caching which needs a whitelist:

The actions bitcoin/bitcoin/.github/actions/clear-files@master, bitcoin/bitcoin/.github/actions/configure-environment@master, bitcoin/bitcoin/.github/actions/restore-caches@master, bitcoin/bitcoin/.github/actions/configure-docker@master, and bitcoin/bitcoin/.github/actions/save-caches@master are not allowed in bitcoin-core/libmultiprocess because all actions must be from a repository owned by bitcoin-core or match one of the patterns: actions/checkout@*, cachix/install-nix-action@*, vmactions/*.

@Sjors Sjors mentioned this pull request Mar 11, 2026
@ryanofsky
Copy link
Copy Markdown
Collaborator Author

Thanks! Closing this in favor of #253. For future reference, it seems like you need to go to the https://github.com/bitcoin-core/libmultiprocess/actions page to see the startup errors, and you can't see errors by using the CI links on the PR page

@ryanofsky ryanofsky closed this Mar 11, 2026
ryanofsky added a commit that referenced this pull request Mar 25, 2026
55a9b55 ci: set Bitcoin Core CI test repetition (Sjors Provoost)
fb0fc84 ci: add TSan job with instrumented libc++ (Sjors Provoost)
0f29c38 ci: add Bitcoin Core IPC tests (ASan + macOS) (Sjors Provoost)

Pull request description:

  Slightly more elaborate version of #252 with ccache and depends caching.

ACKs for top commit:
  ryanofsky:
    Light code review ACK 55a9b55. I looked at all the code here and confirmed it should be safe and the build steps make sense. But did not look closely enough to follow all the internal logic and be very sure there aren't bugs.

Tree-SHA512: 4ae72a4603241678a3cd4d41e9e68c4587759279f356e7f51a3e368aec800cac2548e4d55cd1e268406ada6e6977d6a8a7b2dcdb52291208444d5e3b70701e64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants