Improve RunScript/script components#248
Merged
Merged
Conversation
janezd
force-pushed
the
improve-script-elements
branch
from
203b7ef to
f810881
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the MDX ingestion/rendering pipeline to make <RunScript> easier to author in MDX and to ensure raw <script> tags are executed by converting them into <RunScript> during ingestion.
Changes:
- Added a new remark plugin that rewrites
<RunScript>...</RunScript>and<script>...</script>into<RunScript code="..."/>. - Wired the new plugin into the MDX compile step.
- Updated the runtime
RunScriptcomponent implementation to eval acodeprop instead of usingchildren.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ingest/plugins.ts | Adds backtickRunScript remark plugin to rewrite <script>/<RunScript> nodes into <RunScript code="...">. |
| ingest/md-helpers.ts | Registers the new remark plugin in the MDX compilation pipeline. |
| components/MdxContent.tsx | Updates the MDX component mapping for RunScript to eval a code prop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+158
to
+169
| RunScript: ({code}: {code: string}) => { | ||
| React.useEffect(() => { | ||
| if (window === undefined) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| eval(children); | ||
| eval(code); | ||
| } catch (err) { | ||
| console.error("RunScript error:", err); | ||
| } | ||
| }, [children]), | ||
| }, [code]) | ||
| }, |
This was referenced Jun 14, 2026
Closed
janezd
force-pushed
the
improve-script-elements
branch
from
f810881 to
96d3b1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important: After merging this, rerun ingestion for
notesandpumice.RunScriptused to pass the code as children, now it uses a propcode, so the currently compiled code in the database won't work.Implement a remark plugin that eliminates the need to enclose RunScript children into `{``.
Also replace
<script>elements with<RunScript>so that they're executed.