Strip generated script tags from MDX output#244
Closed
jpers1 wants to merge 1 commit into
Closed
Conversation
77f507f to
11ac8af
Compare
Contributor
Author
|
Reviewer note: the script-node cleanup is intentionally after This should not regress copy-button behavior here because the repo already wires copy interactions separately in the client code rather than depending on inline script execution from the MDX output. |
Contributor
|
Closed in favour of #248. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strip generated
<script>elements from MDX output afterrehype-expressive-coderuns.Why
Fenced code blocks are valid supported content in notes, but
rehype-expressive-codeinjects script elements into the generated output. That output is later rendered through React inMdxContent, which triggers a client-side warning because scripts inside rendered React component output are not executed.This shows up as a runtime warning when serving content with fenced code blocks, even though the author content itself does not contain raw
<script>tags.Changes
scriptelements from the generated treerehype-expressive-codeScope
This PR is intentionally narrow:
The goal is to keep the existing code-block rendering while removing the part of the generated output that React/Next warns about.
Validation
scriptelement in its outputNotes
This is separate from Markdown table support because the issue and fix are unrelated. Tables require parser support; this issue is about generated code-block output from the rehype stage.