New menu-related widgets#24784
Conversation
* FeathersLazyMenu * FeathersMenuToolButton
| align_items: AlignItems::Stretch, | ||
| } | ||
| FeathersMenu | ||
| on(on_lazy_menu_event) |
There was a problem hiding this comment.
Minor nit: on(on_xxxx doesn't read nice but i know it makes sense from a function naming convention
There was a problem hiding this comment.
Agreed, although the convention predates the on() helper and I've been too lazy to change it. Grammatically, you'd think that the preposition "on" would apply to an event, not a handler for the event.
| /// | ||
| /// This is spawnable by inheriting it as a "scene component" with optional [`FeathersMenuButtonProps`]. | ||
| #[derive(SceneComponent, Default, Clone)] | ||
| #[scene(FeathersMenuButtonProps)] |
There was a problem hiding this comment.
Just for my understanding but why are props derived as a scene?
There was a problem hiding this comment.
That's not what is happening. It's saying that the props for FeathersMenuToolButton is FeathersMenuButtonProps.
There was a problem hiding this comment.
Oh interesting - perhaps i need to read up on #[scene] because i would've thought it was ultimately creating a scene, which seemed strange to do for properties
Zeophlite
added
A-UI
Zeophlite
added
the
S-Needs-Review
|
One improvement that I think is blocked by bsn spawn events is to show some immediate feedback while the menu is loading |
Yes, cart and I have discussed this, in particular the idea of having some automated way to preload the assets referenced in the dropdown. However, that's a future research project. |
kfc35
added
S-Ready-For-Final-Review
4 participants
See release notes for description