Elliptical border radius support#24779
Open
ickshonpe wants to merge 17 commits into
Open
Conversation
Changed ResolvedBorderRadius fields to type Vec2
… border radius values
ickshonpe
force-pushed
the
elliptical-radius
branch
from
a11ab49 to
4db663c
Compare
ickshonpe
added
A-Rendering
Contributor
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Add elliptical border radius support.
Fixes #24782
Solution
Changes are relatively simple, mostly API related boiler plate.
BorderRadiusfields are nowVal2s.ResolvedBorderRadiusare nowVec2s.ComputedNode::contains_point, picking should respect the borders of elliptical nodes.Some of the examples and doc tests still need to be updated. The implementation is working though and ready for review.
Testing
New testbed scene:
Showcase