Added focus_only_visible setting to TabNavigationPlugin.#24769
Open
Cyannide wants to merge 3 commits into
Open
Added focus_only_visible setting to TabNavigationPlugin.#24769Cyannide wants to merge 3 commits into
Cyannide wants to merge 3 commits into
Conversation
In most cases invisible components should not be part of the focus cycle. This commit keeps the existing behavior as the default.
Cyannide
force-pushed
the
add_visibility_limit_to_tabnaviation
branch
from
23df688 to
192ebfe
Compare
The ambiguity_detection example was panicking because of the missing config resource.
kfc35
added
C-Feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
In most cases invisible components should not be part of the focus cycle. This commit keeps the existing behavior as the default.
Solution
Added plugin and tabgroup level settings to control the behavior.
Testing
Tested on a local project, you can set components in one of the existing examples with Visibility::Hidden and depending on the plugin/tabgroup setting, the cycle will traverse or skip the hidden components.