Solari: Fix removed RaytracingMesh3d component

[JMS55]

Fixes #24042.

[kfc35]

Any reason why this isn’t using the SyncComponentPlugin stuff? like:
SyncComponentPlugin::<RaytracingMesh3d, Self>::default()

https://docs.rs/bevy/latest/bevy/render/sync_component/struct.SyncComponentPlugin.html
https://github.com/bevyengine/bevy/blob/main/crates/bevy_render/src/sync_component.rs#L48-L63

[JMS55]

I don't really get how/when to use SyncComponentPlugin tbh.

[kfc35]

I don't really get how/when to use SyncComponentPlugin tbh.

From what I understand, you just need to add the plugin on the app and it should just work. I think I'd place it in the RaytracingScenePlugin since the RaytracingMesh3d component is manually extracted in extract_raytracing_scene.

I’m only familiar with this cause lights are set up with their own SyncComponentPlugin’s so I was able to remove manual removal code that had to deal with lights like this. Lights are manually extracted so they don’t use the ExtractComponentPlugin, but they have SyncComponentPlugins to manage any cleanup that needs to happen.impl SyncComponent is only necessary if there are additional components that should be removed when the main world counterpart is removed. @kristoff3r can probably explain more / verify if what I said is correct (author of #22766 )

[kristoff3r]

I don't really get how/when to use SyncComponentPlugin tbh.

From what I understand, you just need to add the plugin on the app and it should just work. I think I'd place it in the RaytracingScenePlugin since the RaytracingMesh3d component is manually extracted in extract_raytracing_scene.

I’m only familiar with this cause lights are set up with their own SyncComponentPlugin’s so I was able to remove manual removal code that had to deal with lights like this. Lights are manually extracted so they don’t use the ExtractComponentPlugin, but they have SyncComponentPlugins to manage any cleanup that needs to happen.impl SyncComponent is only necessary if there are additional components that should be removed when the main world counterpart is removed. @kristoff3r can probably explain more / verify if what I said is correct (author of #22766 )

That is correct. Just like ExtractComponentPlugin is a helper for extraction, SyncComponentPlugin is a helper for removal. If you use the ExtractComponent derive it can also be used from there, see https://docs.rs/bevy/latest/bevy/render/extract_component/derive.ExtractComponent.html

Edit: In this case I think it's fine, this is easier than using the SyncComponent machinery. My hope is that some day we'll have ergonomic ways to handle all the extraction cases that come with syncing included, and at that point we can remove all the ad-hoc stuff and be free from retained render world errors forever.