Set TextLayoutInfo::scale_factor in update_text_layout_info#24245
Open
ickshonpe wants to merge 1 commit into
Open
Set TextLayoutInfo::scale_factor in update_text_layout_info#24245ickshonpe wants to merge 1 commit into
TextLayoutInfo::scale_factor in update_text_layout_info#24245ickshonpe wants to merge 1 commit into
Conversation
…ate function with the value taken from the parley `Layout`, not the caller. * `TextLayoutInfo::size` should be in physical pixels, like the rest of the layout properties, and, again, set b he text layout update function, not the caller.
ickshonpe
added
A-UI
ickshonpe
added
A-Text
kfc35
added
S-Needs-Review
Zeophlite
approved these changes
May 12, 2026
Zeophlite
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
TextLayoutInfo::scale_factorshould be set duringupdate_text_layout_infowith the value taken from the parleyLayout, responsibility should not be with the caller.TextLayoutInfo::sizeis scaled to be in logical pixels, this isn't consistant with other UI layout values that are kept in physical pixels.Solution
TextLayoutInfo::scale_factorinupdate_text_layout_infowith the value taken from the parleyLayout.scale_factorand scalingsizefrom the text2d and UI text systems.