Provide Set Enum for scene_spawner systems#22465
Merged
mockersf merged 3 commits intobevyengine:mainfrom Jan 11, 2026
Merged
Conversation
Implement a solution for bevyengine#22325 Copy minimal example from `TransformSystem` and apply it to minimal necessary source in `scene_spawner.rs`. Basically, created a new label and added the respective systems in it.
mrchantey
approved these changes
Jan 10, 2026
Contributor
mrchantey
left a comment
mrchantey
left a comment
There was a problem hiding this comment.
Simple, well documented, fixes an undestandable issue, lgtm!
kfc35
approved these changes
Jan 10, 2026
kfc35
added
C-Feature
Shatur
suggested changes
Jan 10, 2026
Contributor
Shatur
left a comment
Shatur
left a comment
There was a problem hiding this comment.
Thank you! Minor docs suggestion.
Contributor
|
Trivial enough to include in 0.18. |
Co-authored-by: Hennadii Chernyshchyk <genaloner@gmail.com>
mockersf
approved these changes
Jan 11, 2026
alice-i-cecile
pushed a commit
that referenced
this pull request
Jan 13, 2026
# Objective Fixes #22325 ## Solution Copy minimal example from `TransformSystem` and apply it to minimal necessary source in `scene_spawner.rs`. Basically, created a new label and added the respective systems in it. ## Testing Didn't think I needed to test it since it's p small and I didn't see any tests specifically revolving around `TransformSystem`'s label, but happy to do so if reviewers deem it necessary (first time trying to contribute in a long time). --------- Co-authored-by: Hennadii Chernyshchyk <genaloner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22325
Solution
Copy minimal example from
TransformSystemand apply it to minimal necessary source inscene_spawner.rs. Basically, created a new label and added the respective systems in it.Testing
Didn't think I needed to test it since it's p small and I didn't see any tests specifically revolving around
TransformSystem's label, but happy to do so if reviewers deem it necessary (first time trying to contribute in a long time).