fix: ddl: a column with a negative scale stops replication - #331
Open
Naros wants to merge 1 commit into
Open
Conversation
Reading a system table column rejected every negative number before the value was dispatched on the type of the column being read, so a table with a column such as NUMBER(8,-2) ended replication with a column type mismatch for SYS.COL$ as soon as its definition was read. The branches that follow already reject a negative value for the types that cannot hold one, and the signed branch reads it with strtol. Leave the decision to them. Only SCALE, PRECISION# and NULL$ are affected, all of them signed, all of them using a negative value to mean the column is not set.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
It would be helpful if this could be backported to 1.9 or earlier branches, as Debezium is currently not compatible with the latest 2.0 branch on
master.